Skip to content

HBASE-29817 Stop retrying on DoNotRetryIOException when waiting proce… - #7610

Merged
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-29817
Jan 9, 2026
Merged

HBASE-29817 Stop retrying on DoNotRetryIOException when waiting proce…#7610
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-29817

Conversation

@Apache9

Copy link
Copy Markdown
Contributor

…dure result

@Apache9Apache9 self-assigned this Jan 9, 2026
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 16sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall3m 22smaster passed
+1 💚compile0m 23smaster passed
+1 💚javadoc0m 20smaster passed
+1 💚shadedjars6m 45sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall3m 4sthe patch passed
+1 💚compile0m 23sthe patch passed
+1 💚javac0m 23sthe patch passed
+1 💚javadoc0m 18sthe patch passed
+1 💚shadedjars6m 44spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit1m 38shbase-client in the patch passed.
24m 45s
SubsystemReport/Notes
DockerClientAPI=1.52 ServerAPI=1.52 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7610/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#7610
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 5f5cbecab95b 6.14.0-1018-aws #18~24.04.1-Ubuntu SMP Mon Nov 24 19:46:27 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / b68ec57
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7610/1/testReport/
Max. process+thread count299 (vs. ulimit of 30000)
modulesC: hbase-client U: hbase-client
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7610/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec2m 45sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ master Compile Tests _
+1 💚mvninstall3m 15smaster passed
+1 💚compile1m 2smaster passed
+1 💚checkstyle0m 19smaster passed
+1 💚spotbugs0m 43smaster passed
+1 💚spotless0m 50sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall2m 52sthe patch passed
+1 💚compile1m 1sthe patch passed
+1 💚javac1m 1sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 18sthe patch passed
+1 💚spotbugs0m 49sthe patch passed
+1 💚hadoopcheck11m 18sPatch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚spotless0m 44spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 11sThe patch does not generate ASF License warnings.
33m 34s
SubsystemReport/Notes
DockerClientAPI=1.52 ServerAPI=1.52 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7610/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#7610
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux 640527ec6bf9 6.14.0-1018-aws #18~24.04.1-Ubuntu SMP Mon Nov 24 19:46:27 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / b68ec57
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count83 (vs. ulimit of 30000)
modulesC: hbase-client U: hbase-client
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7610/1/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request addresses HBASE-29817 by preventing infinite retries when a DoNotRetryIOException occurs during procedure result retrieval. The change improves error handling by distinguishing between retryable and non-retryable exceptions.

Key changes:

  • Modified error handling in getProcedureResult method to check for DoNotRetryIOException and immediately complete the future exceptionally instead of retrying
  • Maintained existing retry behavior for all other exceptions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Apache9
Apache9 merged commit 9e3b53c into apache:masterJan 9, 2026
7 checks passed
Apache9 added a commit that referenced this pull request Jan 9, 2026
…dure result (#7610)
Signed-off-by: Hui Ruan <huiruan@apache.org>
Reviewed-by: Umesh Kumar <9414umeshkumar@gmail.com>
Reviewed-by: Liu Xiao <liuxiao2103@qq.com>
(cherry picked from commit 9e3b53c)
Apache9 added a commit that referenced this pull request Jan 9, 2026
…dure result (#7610)
Signed-off-by: Hui Ruan <huiruan@apache.org>
Reviewed-by: Umesh Kumar <9414umeshkumar@gmail.com>
Reviewed-by: Liu Xiao <liuxiao2103@qq.com>
(cherry picked from commit 9e3b53c)
Apache9 added a commit that referenced this pull request Jan 9, 2026
…dure result (#7610)
Signed-off-by: Hui Ruan <huiruan@apache.org>
Reviewed-by: Umesh Kumar <9414umeshkumar@gmail.com>
Reviewed-by: Liu Xiao <liuxiao2103@qq.com>
(cherry picked from commit 9e3b53c)
Apache9 added a commit that referenced this pull request Jan 9, 2026
…dure result (#7610)
Signed-off-by: Hui Ruan <huiruan@apache.org>
Reviewed-by: Umesh Kumar <9414umeshkumar@gmail.com>
Reviewed-by: Liu Xiao <liuxiao2103@qq.com>
(cherry picked from commit 9e3b53c)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@Apache9@Apache-HBase@Umeshkumar9414@frostruan@liuxiaocs7