Skip to content

HBASE-29838 Run Hadoop Check as a GitHub Action - #7651

Merged
ndimiduk merged 1 commit into
apache:masterfrom
ndimiduk:29838-jdk-checks-master
Feb 6, 2026
Merged

HBASE-29838 Run Hadoop Check as a GitHub Action#7651
ndimiduk merged 1 commit into
apache:masterfrom
ndimiduk:29838-jdk-checks-master

Conversation

@ndimiduk

Copy link
Copy Markdown
Member

No description provided.

@Apache-HBase

This comment has been minimized.

1 similar comment
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

1 similar comment
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@ndimiduk

Copy link
Copy Markdown
MemberAuthor

Looks like we occupied the runner for 6h and then it was aborted.

@Apache9

Copy link
Copy Markdown
Contributor

https://infra.apache.org/github-actions-policy.html

The policy here does not say about the 6 hours timeout...

We can ask infra about the rules and the size of the github runners, our jenkins runners finished in "343m 23s", which was very close to 6 hours, so if the machine of the github runner is weaker, the build will be very easy to cost more than 6 hours...

@ndimiduk

Copy link
Copy Markdown
MemberAuthor

My action itself has timeout-minutes: 600 . i'll try bumping this up.

@ndimiduk

Copy link
Copy Markdown
MemberAuthor

or not. 6h is GH's hard limit, https://docs.github.com/en/actions/reference/limits

@Apache9

Copy link
Copy Markdown
Contributor

Then maybe we should try self hosted github runners? For self hosted runners the execution time limit is 5 days...

@ndimiduk
ndimidukforce-pushed the 29838-jdk-checks-master branch from 1829212 to 352a9a1CompareJanuary 23, 2026 07:03
@ndimiduk

Copy link
Copy Markdown
MemberAuthor

Then maybe we should try self hosted github runners? For self hosted runners the execution time limit is 5 days...

Yes we should bring this back to our CI discussions with Infra. Maybe we can borrow from the pool of new Jenkins workers while we continue to build this out.

Yetus is supposed to provide smart, selective detection of module changes when it decided which tests to run. I think the new .github directory broke that for this run, so I've pushed a change to exclude it, maybe that will help.

I'm also going to see if I can manually parallelize the unit test runs -- maybe break out three separate checks for the three main unit test groups or something like that.

@Apache-HBase

This comment has been minimized.

1 similar comment
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache9

Copy link
Copy Markdown
Contributor

Then maybe we should try self hosted github runners? For self hosted runners the execution time limit is 5 days...

Yes we should bring this back to our CI discussions with Infra. Maybe we can borrow from the pool of new Jenkins workers while we continue to build this out.

Yetus is supposed to provide smart, selective detection of module changes when it decided which tests to run. I think the new .github directory broke that for this run, so I've pushed a change to exclude it, maybe that will help.

I'm also going to see if I can manually parallelize the unit test runs -- maybe break out three separate checks for the three main unit test groups or something like that.

Maybe we could split the UTs run as a seperated github check? Or even more, we could split the UTs run as two seperated check, one has -PrunDevTests(for small/medium tests) and one has -PrunLargeTests(for large tests).

@ndimiduk

Copy link
Copy Markdown
MemberAuthor

Maybe we could split the UTs run as a seperated github check? Or even more, we could split the UTs run as two seperated check, one has -PrunDevTests(for small/medium tests) and one has -PrunLargeTests(for large tests).

Yep, that's exactly my thinking as well. Landing these other cleanup issues and I'll be back.

@ndimiduk
ndimidukforce-pushed the 29838-jdk-checks-master branch from 352a9a1 to adfd056CompareJanuary 23, 2026 12:48
@Apache-HBase

This comment has been minimized.

1 similar comment
@Apache-HBase

This comment has been minimized.

@ndimiduk

Copy link
Copy Markdown
MemberAuthor

Okay this is better. Module selection chose only hbase-examples for running the unit tests.

-1 overall
| Vote | Subsystem | Runtime | Comment
============================================================================
| 0 | reexec | 1m 13s | Docker mode activated. | -0 | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file | | | | --spotbugs-strict-precheck
| | | | --author-ignore-list
| | | | --blanks-eol-ignore-file
| | | | --blanks-tabs-ignore-file
| | | | --quick-hadoopcheck
+---------------------------------------------------------------------------
| | | | Prechecks +---------------------------------------------------------------------------
+---------------------------------------------------------------------------
| | | | master Compile Tests +---------------------------------------------------------------------------
| +1 | mvninstall | 3m 25s | master passed | +1 | compile | 0m 19s | master passed | +1 | javadoc | 0m 17s | master passed | +1 | shadedjars | 4m 47s | branch has no errors when building our | | | | shaded downstream artifacts.
+---------------------------------------------------------------------------
| | | | Patch Compile Tests +---------------------------------------------------------------------------
| +1 | mvninstall | 3m 7s | the patch passed | +1 | compile | 0m 18s | the patch passed | +1 | javac | 0m 18s | the patch passed | +1 | javadoc | 0m 15s | the patch passed | +1 | shadedjars | 4m 51s | patch has no errors when building our | | | | shaded downstream artifacts.
+---------------------------------------------------------------------------
| | | | Other Tests +---------------------------------------------------------------------------
| -1 | unit | 0m 24s | hbase-examples in the patch failed. | | | 19m 12s |
|| Subsystem || Report/Notes ||
============================================================================
| unit | /home/runner/work/hbase/hbase/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-examples.txt |
| Docker | ClientAPI=1.48 ServerAPI=1.48 base: /home/runner/work/hbase/hbase/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/7651 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 9b6b1363e88a 6.11.0-1018-azure #18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / adfd0560c941109283928946bd671a5836604e46 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 72 (vs. ulimit of 30000) |
| modules | C: hbase-examples U: hbase-examples |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org/ |

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@ndimiduk

Copy link
Copy Markdown
MemberAuthor

Looking over out last successful nightly on master, the Large tests on hbase-server still took 7h. I'm looking for other ways to partition this up.

@ndimiduk
ndimidukforce-pushed the 29838-jdk-checks-master branch from adfd056 to ad51411CompareJanuary 23, 2026 16:28
@Apache-HBase

This comment has been minimized.

@ndimiduk

Copy link
Copy Markdown
MemberAuthor

I spot-checked the tests run by large waves 1 and 3 (2 is still running) and they look to contain only the expected tests. I think we're good here.

Any other comments @Apache9 ?

@Apache-HBase

This comment has been minimized.

@ndimiduk
ndimidukforce-pushed the 29838-jdk-checks-master branch from 0c5a250 to 4fbb099CompareFebruary 4, 2026 09:04
@Apache-HBase

This comment has been minimized.

1 similar comment
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

Comment thread.github/workflows/yetus-jdk17-hadoop3-unit-check.yml
@ndimiduk
ndimidukforce-pushed the 29838-jdk-checks-master branch from 4fbb099 to 571a79dCompareFebruary 4, 2026 11:01
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

1 similar comment
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@ndimiduk
ndimidukforce-pushed the 29838-jdk-checks-master branch from 571a79d to 2dcbbd0CompareFebruary 5, 2026 10:24
@Apache-HBase

This comment has been minimized.

1 similar comment
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

Comment threaddev-support/hbase-personality.sh Outdated
@ndimiduk
ndimidukforce-pushed the 29838-jdk-checks-master branch 2 times, most recently from e05c8d1 to add8096CompareFebruary 5, 2026 13:23
@Apache-HBase

This comment has been minimized.

@Apache-HBase

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7651/20/console in case of problems.

1 similar comment
@Apache-HBase

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7651/20/console in case of problems.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 33sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗shelldocs0m 0sShelldocs was not available.
+0 🆗yamllint0m 0syamllint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall3m 2smaster passed
+1 💚compile8m 29smaster passed
+1 💚spotless0m 43sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall2m 57sthe patch passed
+1 💚compile8m 25sthe patch passed
+1 💚javac8m 25sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
-0 ⚠️pylint0m 4s/results-pylint.txtThe patch generated 1 new + 19 unchanged - 0 fixed = 20 total (was 19)
+1 💚shellcheck0m 1sNo new issues.
+1 💚xmllint0m 0sNo new issues.
+1 💚hadoopcheck11m 12sPatch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚spotless0m 44spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 11sThe patch does not generate ASF License warnings.
43m 32s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7651/20/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#7651
Optional Testsdupname asflicense codespell detsecrets shellcheck shelldocs spotless pylint yamllint javac xmllint hadoopcheck compile
unameLinux 50ae92ed5baf 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / add8096
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count192 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7651/20/console
versionsgit=2.34.1 maven=3.9.8 pylint=2.15.5 shellcheck=0.8.0 xmllint=20913
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 13sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall2m 15smaster passed
+1 💚compile1m 39smaster passed
+1 💚javadoc1m 28smaster passed
+1 💚shadedjars4m 22sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall2m 16sthe patch passed
+1 💚compile1m 39sthe patch passed
+1 💚javac1m 39sthe patch passed
+1 💚javadoc1m 28sthe patch passed
+1 💚shadedjars4m 22spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit267m 50sroot in the patch passed.
293m 13s
SubsystemReport/Notes
DockerClientAPI=1.53 ServerAPI=1.53 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7651/20/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#7651
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 86f7204404e4 6.14.0-1018-aws #18~24.04.1-Ubuntu SMP Mon Nov 24 19:46:27 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / add8096
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7651/20/testReport/
Max. process+thread count7781 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7651/20/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache9Apache9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the current one is enough to be merged so we can disable the jenkins pre commit job.

There are still problems like mvninstall is still present in unit check, and the job summary for unit check still needs improvement, etc. Can file new issues for improving.

Thanks @ndimiduk for the great work!

Signed-off-by: Duo Zhang <zhangduo@apache.org>
@ndimiduk
ndimidukforce-pushed the 29838-jdk-checks-master branch from add8096 to 8ec8770CompareFebruary 6, 2026 11:11
@ndimiduk
ndimiduk merged commit d3a4566 into apache:masterFeb 6, 2026
0 of 7 checks passed
@ndimiduk
ndimiduk deleted the 29838-jdk-checks-master branch February 6, 2026 15:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ndimiduk@Apache-HBase@Apache9