Skip to content

HBASE-22710 Wrong result in one case of scan that use raw and version… - #767

Merged
virajjasani merged 2 commits into
apache:masterfrom
bsglz:HBASE-22710
Apr 30, 2020
Merged

HBASE-22710 Wrong result in one case of scan that use raw and version…#767
virajjasani merged 2 commits into
apache:masterfrom
bsglz:HBASE-22710

Conversation

@bsglz

@bsglzbsglz commented Oct 28, 2019

Copy link
Copy Markdown
Contributor

…s and filter together

@Apache-HBase

Apache-HBase commented Oct 28, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
💙reexec1m 7sDocker mode activated.
_ Prechecks _
💚dupname0m 0sNo case conflicting files found.
💚hbaseanti0m 0sPatch does not have any anti-patterns.
💚@author0m 0sThe patch does not contain any @author tags.
💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
💚mvninstall5m 57smaster passed
💚compile0m 56smaster passed
💚checkstyle1m 32smaster passed
💚shadedjars5m 1sbranch has no errors when building our shaded downstream artifacts.
💚javadoc0m 36smaster passed
💙spotbugs4m 26sUsed deprecated FindBugs config; considering switching to SpotBugs.
💚findbugs4m 23smaster passed
_ Patch Compile Tests _
💚mvninstall5m 25sthe patch passed
💚compile0m 57sthe patch passed
💚javac0m 57sthe patch passed
💔checkstyle1m 29shbase-server: The patch generated 2 new + 17 unchanged - 0 fixed = 19 total (was 17)
💚whitespace0m 0sThe patch has no whitespace issues.
💚shadedjars5m 0spatch has no errors when building our shaded downstream artifacts.
💚hadoopcheck17m 12sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚javadoc0m 35sthe patch passed
💚findbugs4m 32sthe patch passed
_ Other Tests _
💔unit31m 24shbase-server in the patch failed.
💚asflicense0m 15sThe patch does not generate ASF License warnings.
93m 14s
ReasonTests
Failed junit testshadoop.hbase.regionserver.TestKeepDeletes
SubsystemReport/Notes
DockerClient=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/1/artifact/out/Dockerfile
GITHUB PR#767
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux fa63e05e842a 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-767/out/precommit/personality/provided.sh
git revisionmaster / d7deafa
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/1/artifact/out/diff-checkstyle-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/1/testReport/
Max. process+thread count671 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 29, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
💙reexec1m 25sDocker mode activated.
_ Prechecks _
💚dupname0m 0sNo case conflicting files found.
💚hbaseanti0m 0sPatch does not have any anti-patterns.
💚@author0m 0sThe patch does not contain any @author tags.
💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
💚mvninstall6m 7smaster passed
💚compile1m 0smaster passed
💚checkstyle1m 29smaster passed
💚shadedjars5m 4sbranch has no errors when building our shaded downstream artifacts.
💚javadoc0m 43smaster passed
💙spotbugs5m 0sUsed deprecated FindBugs config; considering switching to SpotBugs.
💚findbugs4m 58smaster passed
_ Patch Compile Tests _
💚mvninstall6m 8sthe patch passed
💚compile1m 6sthe patch passed
💚javac1m 6sthe patch passed
💔checkstyle1m 29shbase-server: The patch generated 1 new + 17 unchanged - 0 fixed = 18 total (was 17)
💚whitespace0m 0sThe patch has no whitespace issues.
💚shadedjars5m 8spatch has no errors when building our shaded downstream artifacts.
💚hadoopcheck23m 32sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚javadoc0m 50sthe patch passed
💚findbugs5m 32sthe patch passed
_ Other Tests _
💔unit36m 31shbase-server in the patch failed.
💚asflicense0m 20sThe patch does not generate ASF License warnings.
110m 6s
ReasonTests
Failed junit testshadoop.hbase.regionserver.TestKeepDeletes
SubsystemReport/Notes
DockerClient=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/2/artifact/out/Dockerfile
GITHUB PR#767
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux a3861e6cef18 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-767/out/precommit/personality/provided.sh
git revisionmaster / a881678
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/2/artifact/out/diff-checkstyle-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/2/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/2/testReport/
Max. process+thread count673 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/2/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 29, 2019

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
💙reexec0m 33sDocker mode activated.
_ Prechecks _
💚dupname0m 0sNo case conflicting files found.
💚hbaseanti0m 0sPatch does not have any anti-patterns.
💚@author0m 0sThe patch does not contain any @author tags.
💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
💚mvninstall5m 41smaster passed
💚compile0m 59smaster passed
💚checkstyle1m 25smaster passed
💚shadedjars4m 38sbranch has no errors when building our shaded downstream artifacts.
💚javadoc0m 37smaster passed
💙spotbugs4m 12sUsed deprecated FindBugs config; considering switching to SpotBugs.
💚findbugs4m 10smaster passed
_ Patch Compile Tests _
💚mvninstall5m 22sthe patch passed
💚compile0m 57sthe patch passed
💚javac0m 57sthe patch passed
💚checkstyle1m 18sthe patch passed
💚whitespace0m 0sThe patch has no whitespace issues.
💚shadedjars4m 47spatch has no errors when building our shaded downstream artifacts.
💚hadoopcheck17m 35sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚javadoc0m 42sthe patch passed
💚findbugs5m 11sthe patch passed
_ Other Tests _
💚unit164m 59shbase-server in the patch passed.
💚asflicense0m 37sThe patch does not generate ASF License warnings.
227m 21s
SubsystemReport/Notes
DockerClient=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/3/artifact/out/Dockerfile
GITHUB PR#767
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 7bb463416ccb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-767/out/precommit/personality/provided.sh
git revisionmaster / 7b4dd95
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/3/testReport/
Max. process+thread count4213 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/3/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@bsglz

bsglz commented Oct 30, 2019

Copy link
Copy Markdown
ContributorAuthor

@openinx Could you help to review it?

@Apache-HBase

Apache-HBase commented Jan 20, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 24sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 💚mvninstall5m 55smaster passed
+1 💚compile1m 0smaster passed
+1 💚checkstyle1m 14smaster passed
+1 💚shadedjars5m 1sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 38smaster passed
+0 🆗spotbugs5m 9sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs5m 6smaster passed
_ Patch Compile Tests _
+1 💚mvninstall5m 31sthe patch passed
+1 💚compile1m 0sthe patch passed
+1 💚javac1m 0sthe patch passed
+1 💚checkstyle1m 12sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedjars5m 1spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck17m 20sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚javadoc0m 36sthe patch passed
+1 💚findbugs5m 8sthe patch passed
_ Other Tests _
-1 ❌unit164m 38shbase-server in the patch failed.
+1 💚asflicense0m 28sThe patch does not generate ASF License warnings.
227m 56s
ReasonTests
Failed junit testshadoop.hbase.master.procedure.TestSCPWithMetaWithoutZKCoordinated
SubsystemReport/Notes
DockerClient=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/1/artifact/out/Dockerfile
GITHUB PR#767
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 9b3f4689ceba 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-767/out/precommit/personality/provided.sh
git revisionmaster / 569ac12
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/1/testReport/
Max. process+thread count4993 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@gjacoby126

gjacoby126 commented Feb 20, 2020

Copy link
Copy Markdown
Contributor

@bsglz , would you mind rebasing your patch on the newest version of TestStoreScanner?

@bsglz
bsglzforce-pushed the HBASE-22710 branch 2 times, most recently from 9c3f8bf to 3630a77CompareMarch 26, 2020 08:22
@bsglz

bsglz commented Mar 26, 2020

Copy link
Copy Markdown
ContributorAuthor

rebased.

@Apache-HBase

Apache-HBase commented Mar 31, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 30sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall5m 28smaster passed
+1 💚checkstyle1m 7smaster passed
+1 💚spotbugs2m 1smaster passed
_ Patch Compile Tests _
+1 💚mvninstall5m 8sthe patch passed
+1 💚checkstyle1m 7sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck10m 27sPatch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚spotbugs2m 10sthe patch passed
_ Other Tests _
+1 💚asflicense0m 14sThe patch does not generate ASF License warnings.
34m 41s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#767
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 9a4cbc2abf69 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / fded2b9
Max. process+thread count93 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/2/console
versionsgit=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Mar 31, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec3m 3sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall10m 24smaster passed
+1 💚compile1m 45smaster passed
+1 💚shadedjars8m 1sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 58shbase-server in master failed.
_ Patch Compile Tests _
+1 💚mvninstall9m 31sthe patch passed
+1 💚compile1m 40sthe patch passed
+1 💚javac1m 40sthe patch passed
+1 💚shadedjars8m 3spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc1m 2shbase-server in the patch failed.
_ Other Tests _
-0 ⚠️unit10m 0shbase-server in the patch failed.
55m 51s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#767
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 7f924c366059 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / e5a8435
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/2/testReport/
Max. process+thread count698 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/2/console
versionsgit=2.17.1 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Mar 31, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 56sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall8m 11smaster passed
+1 💚compile1m 37smaster passed
+1 💚shadedjars7m 40sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 0smaster passed
_ Patch Compile Tests _
+1 💚mvninstall7m 57sthe patch passed
+1 💚compile1m 24sthe patch passed
+1 💚javac1m 24sthe patch passed
+1 💚shadedjars7m 22spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 57sthe patch passed
_ Other Tests _
-1 ❌unit80m 7shbase-server in the patch failed.
119m 13s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#767
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 14738af39ee3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / fded2b9
Default Java1.8.0_232
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/2/testReport/
Max. process+thread count5801 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/2/console
versionsgit=2.17.1 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani
virajjasani reviewed Apr 26, 2020
View reviewed changes

@virajjasanivirajjasani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments

Comment thread...server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ScanQueryMatcher.java Outdated
Comment thread...server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ScanQueryMatcher.java
Comment threadhbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java Outdated
@Apache-HBase

Apache-HBase commented Apr 26, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 0sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall4m 15smaster passed
+1 💚checkstyle1m 18smaster passed
+1 💚spotbugs2m 17smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 57sthe patch passed
+1 💚checkstyle1m 17sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck13m 2sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs2m 45sthe patch passed
_ Other Tests _
+1 💚asflicense0m 16sThe patch does not generate ASF License warnings.
39m 55s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#767
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux fe40ef950871 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / ec0d9d7
Max. process+thread count84 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/3/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani
virajjasani reviewed Apr 26, 2020
View reviewed changes

@virajjasanivirajjasani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, pending QA. Let's wait for other reviews too.

@virajjasani

virajjasani commented Apr 26, 2020

Copy link
Copy Markdown
Contributor

Please review @yangzhe1991@Apache9

@Apache-HBase

Apache-HBase commented Apr 26, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 59sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall4m 17smaster passed
+1 💚compile1m 3smaster passed
+1 💚shadedjars5m 49sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 42smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 58sthe patch passed
+1 💚compile1m 1sthe patch passed
+1 💚javac1m 1sthe patch passed
+1 💚shadedjars5m 39spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 38sthe patch passed
_ Other Tests _
-1 ❌unit202m 24shbase-server in the patch failed.
229m 14s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#767
Optional Testsjavac javadoc unit shadedjars compile
unameLinux f5c255bed837 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / ec0d9d7
Default Java1.8.0_232
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/3/testReport/
Max. process+thread count3281 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/3/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 26, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 46sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall4m 39smaster passed
+1 💚compile1m 9smaster passed
+1 💚shadedjars5m 49sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 42shbase-server in master failed.
_ Patch Compile Tests _
+1 💚mvninstall4m 26sthe patch passed
+1 💚compile1m 10sthe patch passed
+1 💚javac1m 10sthe patch passed
+1 💚shadedjars5m 42spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 40shbase-server in the patch failed.
_ Other Tests _
-1 ❌unit215m 9shbase-server in the patch failed.
242m 52s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#767
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 33576f418bf6 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / ec0d9d7
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/3/testReport/
Max. process+thread count3395 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/3/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

saintstack
saintstack approved these changes Apr 27, 2020
View reviewed changes

@saintstacksaintstack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Thanks for the patch @bsglz

If good by you @virajjasani , I can merge.

@bsglz

bsglz commented Apr 28, 2020

Copy link
Copy Markdown
ContributorAuthor

Thanks very much to all of the reviewers.

Apache9
Apache9 requested changes Apr 28, 2020
View reviewed changes

@Apache9Apache9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC this has been discussed several times in the past, that whether we should suppor filtering when using raw scan.

The problem here is that, for a raw scan, the delete markers will also be returned, and this may cause strange behavior for some filters...

@bsglz

bsglz commented Apr 28, 2020

Copy link
Copy Markdown
ContributorAuthor

IIRC this has been discussed several times in the past, that whether we should suppor filtering when using raw scan.

The problem here is that, for a raw scan, the delete markers will also be returned, and this may cause strange behavior for some filters...

I have skimed the discuss in HBASE-16322, so finaly, as you mentioned, "we do have some usages which use raw scan and filter together",
IMO, since the raw is not only for delete, also for ttl(HBASE-17956) and max version, make its behavier reasonable as far as possible is useful, even if it's not perfect.

@bsglz

bsglz commented Apr 30, 2020

Copy link
Copy Markdown
ContributorAuthor

@saintstack Could you merge it, thanks.

@virajjasani
virajjasani merged commit b810c9b into apache:masterApr 30, 2020
@virajjasani

virajjasani commented Apr 30, 2020

Copy link
Copy Markdown
Contributor

Merged the PR. Thanks @bsglz

virajjasani pushed a commit that referenced this pull request Apr 30, 2020
@bsglz@virajjasani
HBASE-22710Wrong result in one case of scan that use raw and version… (
a6aea72
#767)
Signed-off-by: stack <stack@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
virajjasani pushed a commit that referenced this pull request Apr 30, 2020
@bsglz@virajjasani
HBASE-22710Wrong result in one case of scan that use raw and version… (
4262c72
#767)
Signed-off-by: stack <stack@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
@bsglz

bsglz commented Apr 30, 2020

Copy link
Copy Markdown
ContributorAuthor

Thanks very much.

virajjasani pushed a commit that referenced this pull request Apr 30, 2020
@bsglz@virajjasani
HBASE-22710Wrong result in one case of scan that use raw and version… (
4c42d1b
#767)
Signed-off-by: stack <stack@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
@bsglzmeiyi
HBASE-22710 Wrong result in one case of scan that use raw and version… (
1e3731e
apache#767)
Signed-off-by: stack <stack@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request May 24, 2021
@bsglz@virajjasani
HBASE-22710 Wrong result in one case of scan that use raw and version… (
81cac56
apache#767)
Signed-off-by: stack <stack@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
(cherry picked from commit 4c42d1b)
Change-Id: I829d21551b625ab6217e4b10c12dcae0a2a327b9
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saintstacksaintstacksaintstack approved these changes
@Apache9Apache9Apache9 approved these changes
@virajjasanivirajjasanivirajjasani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bsglz@Apache-HBase@gjacoby126@virajjasani@saintstack@Apache9