HBASE-23224 Delete the TODO tag

[q977734161]

HBASE-23224 Delete the TODO ("get rid of allocations") tag in the WALProcedureStore class

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
💙	reexec	1m 10s	Docker mode activated.
		_ Prechecks _
💚	dupname	0m 0s	No case conflicting files found.
💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
💚	@author	0m 0s	The patch does not contain any @author tags.
💛	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
💚	mvninstall	5m 56s	master passed
💚	compile	0m 18s	master passed
💚	checkstyle	0m 16s	master passed
💚	shadedjars	5m 9s	branch has no errors when building our shaded downstream artifacts.
💚	javadoc	0m 18s	master passed
💙	spotbugs	0m 47s	Used deprecated FindBugs config; considering switching to SpotBugs.
💚	findbugs	0m 45s	master passed
		_ Patch Compile Tests _
💚	mvninstall	6m 5s	the patch passed
💚	compile	0m 21s	the patch passed
💚	javac	0m 21s	the patch passed
💚	checkstyle	0m 16s	the patch passed
💚	whitespace	0m 0s	The patch has no whitespace issues.
💚	shadedjars	5m 22s	patch has no errors when building our shaded downstream artifacts.
💚	hadoopcheck	17m 33s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚	javadoc	0m 15s	the patch passed
💚	findbugs	0m 47s	the patch passed
		_ Other Tests _
💚	unit	3m 36s	hbase-procedure in the patch passed.
💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		55m 15s

Subsystem	Report/Notes
Docker	Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-768/1/artifact/out/Dockerfile
GITHUB PR	#768
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 9c3d361ce911 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-768/out/precommit/personality/provided.sh
git revision	master / d7deafa
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-768/1/testReport/
Max. process+thread count	266 (vs. ulimit of 10000)
modules	C: hbase-procedure U: hbase-procedure
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-768/1/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

[xcangCRM]

should be syncMetricsQueueIndex++; ?

[q977734161]

Yes, syncMetricsQueueIndex ++ in order reuse next SyncMetrics Object in syncMetricsQueue.