Skip to content

HBASE-29454 Update hbase-examples scripts to be compatible with Python 3 - #7687

Merged
guluo2016 merged 2 commits into
apache:branch-2from
liuxiaocs7:HBASE-29454-branch-2
Mar 2, 2026
Merged

HBASE-29454 Update hbase-examples scripts to be compatible with Python 3#7687
guluo2016 merged 2 commits into
apache:branch-2from
liuxiaocs7:HBASE-29454-branch-2

Conversation

@liuxiaocs7

@liuxiaocs7liuxiaocs7 commented Jan 29, 2026

Copy link
Copy Markdown
Member

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 14sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗shelldocs0m 0sShelldocs was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 23sbranch-2 passed
+1 💚spotless0m 39sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall2m 12sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
-0 ⚠️pylint0m 47s/results-pylint.txtThe patch generated 16 new + 1895 unchanged - 3 fixed = 1911 total (was 1898)
+1 💚shellcheck0m 0sNo new issues.
+1 💚spotless0m 37spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 25sThe patch does not generate ASF License warnings.
9m 17s
SubsystemReport/Notes
DockerClientAPI=1.53 ServerAPI=1.53 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7687/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#7687
Optional Testsdupname asflicense codespell detsecrets spotless javac pylint shellcheck shelldocs
unameLinux 6f073b81d39e 6.14.0-1018-aws #18~24.04.1-Ubuntu SMP Mon Nov 24 19:46:27 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 8ca031c
Default JavaEclipse Adoptium-11.0.23+9
Max. process+thread count61 (vs. ulimit of 30000)
modulesC: hbase-server hbase-examples . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7687/1/console
versionsgit=2.34.1 maven=3.9.8 pylint=2.15.5 shellcheck=0.8.0
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@liuxiaocs7

liuxiaocs7 commented Jan 29, 2026

Copy link
Copy Markdown
MemberAuthor

Hi, @guluo2016, maybe we should backport HBASE-25508 for branch-2 first, WDYT?

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 54sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall3m 32sbranch-2 passed
+1 💚javadoc2m 33sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall3m 8sthe patch passed
+1 💚javadoc2m 28sthe patch passed
_ Other Tests _
-1 ❌unit303m 53s/patch-unit-root.txtroot in the patch failed.
324m 47s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7687/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#7687
Optional Testsjavac javadoc unit
unameLinux ffa71e8ee27d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 8ca031c
Default JavaEclipse Adoptium-11.0.23+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7687/1/testReport/
Max. process+thread count6670 (vs. ulimit of 30000)
modulesC: hbase-server hbase-examples . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7687/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec1m 19sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall4m 36sbranch-2 passed
+1 💚javadoc3m 57sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall4m 12sthe patch passed
+1 💚javadoc4m 25sthe patch passed
_ Other Tests _
-1 ❌unit341m 35s/patch-unit-root.txtroot in the patch failed.
368m 23s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7687/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#7687
Optional Testsjavac javadoc unit
unameLinux 6358ce4db4bc 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 8ca031c
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7687/1/testReport/
Max. process+thread count3582 (vs. ulimit of 30000)
modulesC: hbase-server hbase-examples . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7687/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec1m 18sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall3m 58sbranch-2 passed
+1 💚javadoc3m 39sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall3m 22sthe patch passed
+1 💚javadoc3m 7sthe patch passed
_ Other Tests _
-1 ❌unit458m 59s/patch-unit-root.txtroot in the patch failed.
481m 41s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7687/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#7687
Optional Testsjavac javadoc unit
unameLinux 5b03e3f2e534 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 8ca031c
Default JavaTemurin-1.8.0_412-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7687/1/testReport/
Max. process+thread count3434 (vs. ulimit of 30000)
modulesC: hbase-server hbase-examples . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7687/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@guluo2016
guluo2016 self-requested a review January 29, 2026 15:51

@guluo2016guluo2016 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

Comment threadhbase-examples/src/main/python/thrift1/DemoClient.py

@guluo2016guluo2016 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liuxiaocs7

liuxiaocs7 commented Feb 2, 2026

Copy link
Copy Markdown
MemberAuthor

It seems that the PR of the master also has the same error. https://github.com/apache/hbase/pull/7161/changes#diff-e15b3229b250eefccf1b45a8c54b9130b3905dabd6aef6d8cfda912bea1bb982R142-R143:~:text=142-,for%20e%20in%20range(100%2C%200%2C%20%2D1,row%20%3D%20f%22%7Brow%3A05%7D%22,-153

Hi, @guluo2016, thanks for your reviewing, branch-2 miss some PRs, before backport HBASE-23644 and HBASE-29457, seems we should backprot HBASE-25508 and HBASE-29454. The errors which you pointed will be fix by HBASE-29457(#7529) and HBASE-23644 (#7530) i think, thanks!!!

@liuxiaocs7

liuxiaocs7 commented Feb 2, 2026

Copy link
Copy Markdown
MemberAuthor

For branch-3, first backport HBASE-29454 (#7671) and then HBASE-23644/HBASE-29457
For branch-2, first backprot HBASE-25508, and then HBASE-29454, finally HBASE-23644/HBASE-29457
@guluo2016, WDYT, this pr is mixed of HBASE-25508 and HBASE-29454, we'd better close it?

@guluo2016

Copy link
Copy Markdown
Member

It is better to create a PR for each issue, and it's better to based on the latest code

@liuxiaocs7

liuxiaocs7 commented Feb 2, 2026

Copy link
Copy Markdown
MemberAuthor

It is better to create a PR for each issue, and it's better to based on the latest code

Hi, @guluo2016, thanks for reviewing and kindly suggestions, i'll close this pr and raise one by one for branch-2 if needed, code for branch-3 (apache/hbase#7671) seems that there is no such mixed commit issue, plz take a look when free, thanks!

@liuxiaocs7

liuxiaocs7 commented Feb 6, 2026

Copy link
Copy Markdown
MemberAuthor

Hi, @guluo2016, as mentioned above, backport HBASE-25508(#7715) for branch-2 has been created, please help take a look when free, thanks!

@guluo2016

Copy link
Copy Markdown
Member

Please update this PR or open a new PR, thanks! @liuxiaocs7

@liuxiaocs7

Copy link
Copy Markdown
MemberAuthor

Please update this PR or open a new PR, thanks! @liuxiaocs7

Hi, @guluo2016, thanks for the reminder, i'll update this PR

@liuxiaocs7
liuxiaocs7force-pushed the HBASE-29454-branch-2 branch 4 times, most recently from 61c8722 to bd74099CompareFebruary 13, 2026 15:52
@liuxiaocs7

Copy link
Copy Markdown
MemberAuthor

For branch-3, first backport HBASE-29454 (#7671) and then HBASE-23644/HBASE-29457 For branch-2, first backprot HBASE-25508, and then HBASE-29454, finally HBASE-23644/HBASE-29457@guluo2016, WDYT, this pr is mixed of HBASE-25508 and HBASE-29454, we'd better close it?

Hi, @guluo2016, now we can work for branch-2, this PR has been updated and only for HBASE-29454, could you help take a look when free, thanks!

@guluo2016

Copy link
Copy Markdown
Member

The failure seems unrelated to the PR, let me re-run the job

kgeiszand others added 2 commits February 27, 2026 23:41
…on 3 (apache#7161)
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
Reviewed by: Kota-SH <shanmukhaharipriya@gmail.com>
@guluo2016

Copy link
Copy Markdown
Member

This failure is unrelated to these changes.

@guluo2016
guluo2016 merged commit b0aa374 into apache:branch-2Mar 2, 2026
14 of 29 checks passed
guluo2016 pushed a commit that referenced this pull request Mar 2, 2026
…n 3 (#7687)
Signed-off-by: Peng Lu <lupeng@apache.org>
Co-authored-by: Kevin Geiszler <kgeiszler@cloudera.com>
guluo2016 pushed a commit that referenced this pull request Mar 2, 2026
…n 3 (#7687)
Signed-off-by: Peng Lu <lupeng@apache.org>
Co-authored-by: Kevin Geiszler <kgeiszler@cloudera.com>
@liuxiaocs7

Copy link
Copy Markdown
MemberAuthor

Thanks @guluo2016 for reviewing and merging, i'll continue the work on branch-2.x ASAP.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@liuxiaocs7@Apache-HBase@guluo2016@kgeisz