HBASE-29843 HBaseRPCController.setPriority(final TableName tn) is nev… by Apache9 · Pull Request #7692 · apache/hbase

Apache9 · 2026-01-29T15:37:39Z

…er called on branch-3+

Apache-HBase · 2026-01-29T16:39:24Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 28s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 52s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 14s		master passed
+1 💚	compile	4m 13s		master passed
+1 💚	checkstyle	1m 18s		master passed
+1 💚	spotbugs	2m 20s		master passed
+1 💚	spotless	0m 49s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 33s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 54s		the patch passed
+1 💚	compile	4m 10s		the patch passed
+1 💚	javac	4m 10s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 15s		the patch passed
+1 💚	spotbugs	2m 30s		the patch passed
+1 💚	hadoopcheck	11m 16s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚	spotless	0m 45s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 20s		The patch does not generate ASF License warnings.
		45m 8s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7692/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7692
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 8d32ef3a1499 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f68f19b`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	84 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7692/1/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2026-01-29T20:00:14Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 12s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 20s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 34s		master passed
+1 💚	compile	1m 5s		master passed
+1 💚	javadoc	0m 38s		master passed
+1 💚	shadedjars	4m 30s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 21s		the patch passed
+1 💚	compile	1m 4s		the patch passed
+1 💚	javac	1m 4s		the patch passed
+1 💚	javadoc	0m 35s		the patch passed
+1 💚	shadedjars	4m 30s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	1m 21s		hbase-client in the patch passed.
-1 ❌	unit	222m 52s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		246m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.53 ServerAPI=1.53 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7692/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7692
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux c520210476a7 6.14.0-1018-aws #18~24.04.1-Ubuntu SMP Mon Nov 24 19:46:27 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f68f19b`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7692/1/testReport/
Max. process+thread count	5040 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7692/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2026-01-30T09:57:55Z

@stoty Please see if this could solve Phoenix's problem? I introduced a new setPriority method and the default implementation in the interface is call setPriority(int) and then setPriority(TableName).

Thanks.

richardantal · 2026-02-12T08:51:33Z

 (int) Math.min(Integer.MAX_VALUE, TimeUnit.NANOSECONDS.toMillis(timeoutNs)));
 }
- controller.setPriority(priority);
+ controller.setPriority(priority, tableName);


Thank you for this change.
I think we could make this work from the Phoenix side with adding a function to https://github.com/apache/phoenix/blob/master/phoenix-core-client/src/main/java/org/apache/hadoop/hbase/ipc/controller/MetadataRpcController.java#L70
public void setPriority(int priority, final TableName tn) { setPriority(tn); }

With this change in place, Phoenix does not need any change, since the default method of setPriority(int, TableName) is to call setPriority(int) and then setPriority(TableName).

When we call controller.setPriority(priority, tableName); on the metadataRpcController which doesn't have a setPriority(priority, tableName) method it results calling the
DelegatingHBaseRpcController's setPriority(int priority, @Nullable TableName tableName) method
It calls the delegate.setPriority(priority, tableName) ( not setPriority(int) and then setPriority(TableName) )
Where the delegate is HBaseRpcControllerImpl
So we won't call the MetadataRpcController's setPriority(TableName)

Apache9 · 2026-02-14T14:45:23Z

@richardantal Do you think I should also include this change on 2.x branches? Or just include this in 3.x? Which is better for Phoenix?

richardantal · 2026-02-17T08:20:59Z

For Phoenix it is enough to just include this change to 3.x and master branch.

richardantal

LGTM from phoenix side

wchevreuil · 2026-02-24T12:05:34Z

 tn != null && tn.isSystemTable() ? HConstants.SYSTEMTABLE_QOS : HConstants.NORMAL_QOS);
 }

+ static int calcPriority(int priority, TableName tableName) {


nit: This is never used anywhere.

…er called on branch-3+

PDavid

Thanks, looks good to me. 👍

…er called on branch-3+ (#7692) Signed-off-by: Dávid Paksy <paksyd@apache.org> Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> Reviewed-by: Richárd Antal <richardantal@apache.org> (cherry picked from commit ae8aefc)

Apache9 requested a review from stoty January 29, 2026 15:37

Apache9 self-assigned this Jan 29, 2026

richardantal reviewed Feb 12, 2026
View reviewed changes

Apache9 force-pushed the HBASE-29843 branch 2 times, most recently from 9daf5fd to 5c261a8Compare February 14, 2026 14:44

richardantal approved these changes Feb 17, 2026
View reviewed changes

wchevreuil approved these changes Feb 24, 2026
View reviewed changes

HBASE-29843 HBaseRPCController.setPriority(final TableName tn) is nev…
0ab6e78
…er called on branch-3+

Apache9 force-pushed the HBASE-29843 branch from 5c261a8 to 0ab6e78Compare February 24, 2026 14:10

PDavid approved these changes Feb 25, 2026
View reviewed changes

Apache9 merged commit ae8aefc into apache:masterFeb 25, 2026
5 of 7 checks passed

Navigation Menu

Uh oh!

HBASE-29843 HBaseRPCController.setPriority(final TableName tn) is nev… - #7692

HBASE-29843 HBaseRPCController.setPriority(final TableName tn) is nev…#7692
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-29843

Apache9 commented Jan 29, 2026

Uh oh!

Apache-HBase commented Jan 29, 2026

Uh oh!

Apache-HBase commented Jan 29, 2026

Uh oh!

Apache9 commented Jan 30, 2026

Uh oh!

richardantalFeb 12, 2026

Uh oh!

Apache9Feb 12, 2026

Uh oh!

richardantalFeb 12, 2026

Uh oh!

Apache9 commented Feb 14, 2026

Uh oh!

richardantal commented Feb 17, 2026

Uh oh!

richardantal left a comment

Uh oh!

wchevreuilFeb 24, 2026

Uh oh!

PDavid left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

Apache9 commented Jan 29, 2026

Uh oh!

Apache-HBase commented Jan 29, 2026

Uh oh!

Apache-HBase commented Jan 29, 2026

Uh oh!

Apache9 commented Jan 30, 2026

Uh oh!

richardantalFeb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Apache9Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

richardantalFeb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Apache9 commented Feb 14, 2026

Uh oh!

richardantal commented Feb 17, 2026

Uh oh!

richardantal left a comment

Choose a reason for hiding this comment

Uh oh!

wchevreuilFeb 24, 2026

Choose a reason for hiding this comment

Uh oh!

PDavid left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants