Skip to content

HBASE-29780: Addendum to HBASE-29715: Add an additional test case that uses the filesystem - #7702

Merged
anmolnar merged 1 commit into
apache:HBASE-29081from
kgeisz:HBASE-29780-addendum-HBASE-29715-add-filesystem-test-case
Feb 4, 2026
Merged

HBASE-29780: Addendum to HBASE-29715: Add an additional test case that uses the filesystem#7702
anmolnar merged 1 commit into
apache:HBASE-29081from
kgeisz:HBASE-29780-addendum-HBASE-29715-add-filesystem-test-case

Conversation

@kgeisz

@kgeiszkgeisz commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

https://issues.apache.org/jira/browse/HBASE-29780

This pull request is an addendum to HBASE-29715 (PR #7474). This PR introduces an additional test case that adds table descriptors to both the filesystem and the table descriptor cache, rather than just the cache. This is done by using false instead of true for cacheOnly in master.getTableDescriptors().update().

I also noticed I could create the table descriptor on the filesystem by using the static FSTableDescriptors.createTableDescriptorForTableDirectory() method. However, I would still need to run master.getTableDescriptors().update() after to update the cache. If I didn't update the cache, then the new unit test would still pass even if I reverted the original change to HMaster introduced in the previous PR (#7474). This is why I instead went with using master.getTableDescriptors().update() with cacheOnly set to false because it achieves the same result with fewer lines of code.

…t uses the filesystem
Change-Id: I776f956c830a7f4671cfae265269a21fa61d0bdf
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 12sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ HBASE-29081 Compile Tests _
+1 💚mvninstall2m 38sHBASE-29081 passed
+1 💚compile2m 33sHBASE-29081 passed
-0 ⚠️checkstyle0m 13s/buildtool-branch-checkstyle-hbase-server.txtThe patch fails to run checkstyle in hbase-server
+1 💚spotbugs1m 12sHBASE-29081 passed
+1 💚spotless0m 39sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall2m 16sthe patch passed
+1 💚compile2m 35sthe patch passed
+1 💚javac2m 35sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
-0 ⚠️checkstyle0m 12s/buildtool-patch-checkstyle-hbase-server.txtThe patch fails to run checkstyle in hbase-server
+1 💚spotbugs1m 16sthe patch passed
+1 💚hadoopcheck8m 48sPatch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚spotless0m 34spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 9sThe patch does not generate ASF License warnings.
28m 54s
SubsystemReport/Notes
DockerClientAPI=1.53 ServerAPI=1.53 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7702/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#7702
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux 5c79fa47a2df 6.14.0-1018-aws #18~24.04.1-Ubuntu SMP Mon Nov 24 19:46:27 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-29081 / 5b51408
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count87 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7702/1/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec1m 29sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ HBASE-29081 Compile Tests _
+1 💚mvninstall2m 41sHBASE-29081 passed
+1 💚compile0m 47sHBASE-29081 passed
+1 💚javadoc0m 24sHBASE-29081 passed
+1 💚shadedjars4m 38sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall2m 26sthe patch passed
+1 💚compile0m 48sthe patch passed
+1 💚javac0m 48sthe patch passed
+1 💚javadoc0m 22sthe patch passed
+1 💚shadedjars4m 35spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌unit230m 29s/patch-unit-hbase-server.txthbase-server in the patch failed.
252m 41s
SubsystemReport/Notes
DockerClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7702/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#7702
Optional Testsjavac javadoc unit compile shadedjars
unameLinux f2974547e984 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-29081 / 5b51408
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7702/1/testReport/
Max. process+thread count6440 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7702/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@anmolnaranmolnar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@anmolnar

Copy link
Copy Markdown
Contributor

@kgeisz There are unit test failures, but probably unrelated, because you've just added a new unit test. I'll merge anyways.

@kgeisz

Copy link
Copy Markdown
ContributorAuthor

@kgeisz There are unit test failures, but probably unrelated, because you've just added a new unit test. I'll merge anyways.

@anmolnar Yes, they look unrelated as expected, so I think we are good to merge

@anmolnar
anmolnar merged commit 6dd4db1 into apache:HBASE-29081Feb 4, 2026
1 check failed
anmolnar pushed a commit that referenced this pull request Mar 13, 2026
…t uses the filesystem (#7702)
Change-Id: I776f956c830a7f4671cfae265269a21fa61d0bdf
anmolnar pushed a commit that referenced this pull request Apr 8, 2026
…t uses the filesystem (#7702)
Change-Id: I776f956c830a7f4671cfae265269a21fa61d0bdf
anmolnar pushed a commit that referenced this pull request Apr 10, 2026
…t uses the filesystem (#7702)
Change-Id: I776f956c830a7f4671cfae265269a21fa61d0bdf
anmolnar pushed a commit that referenced this pull request May 5, 2026
…t uses the filesystem (#7702)
Change-Id: I776f956c830a7f4671cfae265269a21fa61d0bdf
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kgeisz@Apache-HBase@anmolnar