Uh oh!
There was an error while loading. Please reload this page.
HBASE-23242: [checkstyle] Make LineLength a child of Checker module. - #783
HBASE-23242: [checkstyle] Make LineLength a child of Checker module.#783bharathv wants to merge 1 commit into
Conversation
As per checkstyle docs[1], it should be placed under Checker. Otherwise intellij complains to import this configuration. [1] https://checkstyle.sourceforge.io/config_sizes.html#LineLength
bharathv
commented
Nov 1, 2019
@saintstack You seemed to have touched this file recently. Can you please take a look? Thanks. |
Apache-HBase
commented
Nov 1, 2019
💔 -1 overall
This message was automatically generated. |
bharathv
commented
Nov 2, 2019
It looks like hbase pulls in an older version of checkstyle and the xml is valid for that version. Intellij defaults to v8.25 which is incompatible (rules have changed). Luckily one can select the checkstyle version in Intellij. So we don't need this hbase side change anymore. We still have to fix the file if we upgrade the checkstyle version but that can be done as a part of a separate change I think. |
busbey
commented
Nov 2, 2019
thanks for chasing this down! |
ndimiduk
commented
Nov 18, 2019
This came up as well in my chat over on checkstyle/checkstyle#7236. |
right now Eclipse and Idea plugins support latest checkstyle (8.26), so update to latest should not problem, but config must be changed. |
As per checkstyle docs[1], it should be placed under Checker. Otherwise
intellij complains to import this configuration.
[1] https://checkstyle.sourceforge.io/config_sizes.html#LineLength