Skip to content

HBASE-23242: [checkstyle] Make LineLength a child of Checker module. - #783

Closed
bharathv wants to merge 1 commit into
apache:masterfrom
bharathv:HBASE-23242
Closed

HBASE-23242: [checkstyle] Make LineLength a child of Checker module.#783
bharathv wants to merge 1 commit into
apache:masterfrom
bharathv:HBASE-23242

Conversation

@bharathv

Copy link
Copy Markdown
Contributor

As per checkstyle docs[1], it should be placed under Checker. Otherwise
intellij complains to import this configuration.

[1] https://checkstyle.sourceforge.io/config_sizes.html#LineLength

As per checkstyle docs[1], it should be placed under Checker. Otherwise
intellij complains to import this configuration.
[1] https://checkstyle.sourceforge.io/config_sizes.html#LineLength
@bharathv

Copy link
Copy Markdown
ContributorAuthor

@saintstack You seemed to have touched this file recently. Can you please take a look? Thanks.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
💙reexec3m 26sDocker mode activated.
_ Prechecks _
💚dupname0m 0sNo case conflicting files found.
💚@author0m 0sThe patch does not contain any @author tags.
💛test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
💚mvninstall5m 50smaster passed
💚checkstyle2m 52smaster passed
💚javadoc0m 12smaster passed
_ Patch Compile Tests _
💚mvninstall5m 30sthe patch passed
💔checkstyle0m 10sThe patch fails to run checkstyle in root
💚whitespace0m 0sThe patch has no whitespace issues.
💚xml0m 1sThe patch has no ill-formed XML file.
💚javadoc0m 11sthe patch passed
_ Other Tests _
💚unit0m 11shbase-checkstyle in the patch passed.
💚asflicense0m 12sThe patch does not generate ASF License warnings.
19m 45s
SubsystemReport/Notes
DockerClient=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-783/1/artifact/out/Dockerfile
GITHUB PR#783
JIRA IssueHBASE-23242
Optional Testsdupname asflicense checkstyle javac javadoc unit xml
unameLinux ba1d27fbf0d9 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-783/out/precommit/personality/provided.sh
git revisionmaster / b8a4504
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-783/1/artifact/out//home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-783/out/maven-patch-checkstyle-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-783/1/testReport/
Max. process+thread count86 (vs. ulimit of 10000)
modulesC: hbase-checkstyle U: hbase-checkstyle
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-783/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@bharathv

Copy link
Copy Markdown
ContributorAuthor

It looks like hbase pulls in an older version of checkstyle and the xml is valid for that version. Intellij defaults to v8.25 which is incompatible (rules have changed). Luckily one can select the checkstyle version in Intellij. So we don't need this hbase side change anymore. We still have to fix the file if we upgrade the checkstyle version but that can be done as a part of a separate change I think.

@bharathvbharathv closed this Nov 2, 2019
@bharathv
bharathv deleted the HBASE-23242 branch November 2, 2019 22:07
@busbey

Copy link
Copy Markdown
Contributor

thanks for chasing this down!

@ndimiduk

Copy link
Copy Markdown
Member

This came up as well in my chat over on checkstyle/checkstyle#7236.

@romani

romani commented Nov 29, 2019

Copy link
Copy Markdown

Intellij defaults to v8.25 which is incompatible

right now Eclipse and Idea plugins support latest checkstyle (8.26), so update to latest should not problem, but config must be changed.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@bharathv@Apache-HBase@busbey@ndimiduk@romani