Skip to content

HBASE-30195 Update Thrift gateway to use new hbase-shaded-thrift in thirdparty - #8299

Merged
apurtell merged 1 commit into
apache:masterfrom
apurtell:HBASE-30195
Jun 26, 2026
Merged

HBASE-30195 Update Thrift gateway to use new hbase-shaded-thrift in thirdparty#8299
apurtell merged 1 commit into
apache:masterfrom
apurtell:HBASE-30195

Conversation

@apurtell

@apurtellapurtell commented Jun 1, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

On apache/hbase-thirdparty#160 we onboard libthrift to hbase-thirdparty so we can consume libthrift security fixes while maintaining Java 8 compatibility for HBase branch-2, branch-2.5, and branch-2.6.

Use the new hbase-shaded-thrift in hbase-thirdparty.

@apurtell
apurtell requested review from Apache9 and PDavidJune 1, 2026 22:57
@apurtellapurtell self-assigned this Jun 1, 2026
@apurtell

apurtell commented Jun 1, 2026•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

I applied this locally and built with -Dhbase-thirdparty=4.1.14-SNAPSHOT and the hbase-thrift test results look good.

Tests run: 155, Failures: 0, Errors: 2, Skipped: 0

The two erroring tests are TestThriftSpnegoHttpFallbackServer and TestThriftSpnegoHttpServer failing on NoMatchingRule: No rules applied to xxx@XXX.XXX.COM

This is an unrelated environmental problem because Kerberos tests using the miniKDC don't install matching rules to handle real kerberos credentials that might be found in a user's environment. I recently fixed that issue in the Phoenix tests and will follow up for HBase on another JIRA

@apurtell

apurtell commented Jun 12, 2026

Copy link
Copy Markdown
ContributorAuthor

Rebased.

Still waiting for hbase-thirdparty release vote before this can come out of draft.

Apache9
Apache9 reviewed Jun 13, 2026
View reviewed changes

@Apache9Apache9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to ban libthrift dependencies completely in maven enforcer?

Comment threadhbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/NamespaceDescriptor.java Outdated

@Apache9Apache9Jun 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this file is gone?

@apurtellapurtellJun 17, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of this work I wiped the generated sources directory and then regenerated the IDL with the thrift compiler version 0.23.0. The IDL has never defined a NamespaceDescriptor as far as I know it has always been TNamespaceDescriptor. I think the old file was an orphan from HBASE-21650 that has been harmlessly hanging around but is not needed.

@apurtell
apurtell marked this pull request as ready for review June 17, 2026 15:45
@apurtell

apurtell commented Jun 17, 2026

Copy link
Copy Markdown
ContributorAuthor

Added an enforcer import ban for org.apache.thrift:*

Rebased on current master.

@apurtell
apurtell requested a review from Apache9June 17, 2026 15:46
Apache9
Apache9 reviewed Jun 18, 2026
View reviewed changes

@Apache9Apache9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add a repository section in pom.xml for building with staging release.

We can remove this section when 4.1.14 is finally out.

@apurtell

apurtell commented Jun 19, 2026

Copy link
Copy Markdown
ContributorAuthor

Done, thank you for the reminder @Apache9

@apurtell@claude
HBASE-30195 Update Thrift gateway to use new hbase-shaded-thrift in t…
af8fc33
…hirdparty
Co-Authored-by: Claude <noreply@anthropic.com>
@apurtell

apurtell commented Jun 23, 2026

Copy link
Copy Markdown
ContributorAuthor

Rebased on latest master after release of hbase-thirdparty-4.1.14. Dropped staging repo.

@apurtellapurtell mentioned this pull request Jun 23, 2026
Merged
@apurtell
apurtell merged commit cce8164 into apache:masterJun 26, 2026
12 of 13 checks passed
@apurtell
apurtell deleted the HBASE-30195 branch June 26, 2026 23:19
asf-gitbox-commits pushed a commit that referenced this pull request Jun 26, 2026
@apurtell@claude
HBASE-30195Update Thrift gateway to use new hbase-shaded-thrift in t…
85d546a
…hirdparty (#8299)
Signed-off-by: Dávid Paksy <paksyd@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Pankaj Kumar <pankajkumar@apache.org>
Signed-off-by: Xiao Liu <liuxiaocs@apache.org>
Co-authored-by: Claude Opus 4.8[1m] <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PDavidPDavidPDavid approved these changes
@Apache9Apache9Apache9 approved these changes
@pankaj72981pankaj72981pankaj72981 approved these changes
@liuxiaocs7liuxiaocs7liuxiaocs7 approved these changes

Assignees

@apurtellapurtell

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@apurtell@PDavid@Apache9@pankaj72981@liuxiaocs7