Skip to content

HBASE-23259: Populate master address end points in cluster/rs configs - #857

Merged
ndimiduk merged 1 commit into
apache:branch-2from
ndimiduk:23259-backport-branch-2
Nov 21, 2019
Merged

HBASE-23259: Populate master address end points in cluster/rs configs#857
ndimiduk merged 1 commit into
apache:branch-2from
ndimiduk:23259-backport-branch-2

Conversation

@ndimiduk

Copy link
Copy Markdown
Member

All the clients need to know the master RPC end points while using master
based registry for creating cluster connections. This patch amends the
test cluster utility to populate these configs in the base configuration
object used to spin up the cluster.

The config key added here ("hbase.master.addrs") is used in the subsequent
patches for HBASE-18095.

Signed-off-by: Nick Dimiduk ndimiduk@apache.org

…apache#807)
All the clients need to know the master RPC end points while using master
based registry for creating cluster connections. This patch amends the
test cluster utility to populate these configs in the base configuration
object used to spin up the cluster.
The config key added here ("hbase.master.addrs") is used in the subsequent
patches for HBASE-18095.
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 38sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall5m 18sbranch-2 passed
+1 💚compile1m 22sbranch-2 passed
+1 💚checkstyle1m 57sbranch-2 passed
+1 💚shadedjars4m 46sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 3sbranch-2 passed
+0 🆗spotbugs4m 1sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs4m 56sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall5m 19sthe patch passed
+1 💚compile1m 17sthe patch passed
+1 💚javac1m 17sthe patch passed
+1 💚checkstyle0m 28sThe patch passed checkstyle in hbase-common
+1 💚checkstyle1m 21shbase-server: The patch generated 0 new + 35 unchanged - 1 fixed = 35 total (was 36)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedjars4m 25spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck15m 28sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚javadoc0m 56sthe patch passed
+1 💚findbugs4m 20sthe patch passed
_ Other Tests _
+1 💚unit3m 0shbase-common in the patch passed.
-1 ❌unit167m 35shbase-server in the patch failed.
+1 💚asflicense1m 4sThe patch does not generate ASF License warnings.
232m 11s
SubsystemReport/Notes
DockerClient=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-857/1/artifact/out/Dockerfile
GITHUB PR#857
JIRA IssueHBASE-23259
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 26b99378b9ea 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-857/out/precommit/personality/provided.sh
git revisionbranch-2 / 7e088da
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-857/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-857/1/testReport/
Max. process+thread count4696 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-857/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@ndimiduk

Copy link
Copy Markdown
MemberAuthor

The only failure here is an instance of HBASE-22470.

@ndimiduk
ndimiduk merged commit d742112 into apache:branch-2Nov 21, 2019
@ndimiduk
ndimiduk deleted the 23259-backport-branch-2 branch November 21, 2019 17:44
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
…apache#807) (apache#857)
All the clients need to know the master RPC end points while using master
based registry for creating cluster connections. This patch amends the
test cluster utility to populate these configs in the base configuration
object used to spin up the cluster.
The config key added here ("hbase.master.addrs") is used in the subsequent
patches for HBASE-18095.
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ndimiduk@Apache-HBase@bharathv