HBASE-23073 Add an optional costFunction to balance regions according to a capacity rule

[PierreZ]

Backport of HBASE-23073

[wchevreuil]

Thanks! Waiting on the pre-commit job to run, before merging it.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	7m 25s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 2 new or modified test files.
		_ branch-1 Compile Tests _
+1 💚	mvninstall	8m 41s	branch-1 passed
+1 💚	compile	0m 41s	branch-1 passed with JDK v1.8.0_232
+1 💚	compile	0m 45s	branch-1 passed with JDK v1.7.0_242
+1 💚	checkstyle	1m 34s	branch-1 passed
+1 💚	shadedjars	2m 52s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	branch-1 passed with JDK v1.8.0_232
+1 💚	javadoc	0m 42s	branch-1 passed with JDK v1.7.0_242
+0 🆗	spotbugs	2m 52s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	2m 49s	branch-1 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	1m 55s	the patch passed
+1 💚	compile	0m 38s	the patch passed with JDK v1.8.0_232
+1 💚	javac	0m 38s	the patch passed
+1 💚	compile	0m 47s	the patch passed with JDK v1.7.0_242
+1 💚	javac	0m 47s	the patch passed
+1 💚	checkstyle	1m 31s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	2m 48s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	4m 59s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚	javadoc	0m 31s	the patch passed with JDK v1.8.0_232
+1 💚	javadoc	0m 41s	the patch passed with JDK v1.7.0_242
-1 ❌	findbugs	2m 55s	hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
-1 ❌	unit	130m 56s	hbase-server in the patch failed.
+1 💚	asflicense	0m 32s	The patch does not generate ASF License warnings.
		178m 2s

Reason	Tests
FindBugs	module:hbase-server
	Primitive value is unboxed and coerced for ternary operator in org.apache.hadoop.hbase.master.balancer.HeterogeneousRegionCountCostFunction.cost() At HeterogeneousRegionCountCostFunction.java:coerced for ternary operator in org.apache.hadoop.hbase.master.balancer.HeterogeneousRegionCountCostFunction.cost() At HeterogeneousRegionCountCostFunction.java:[line 134]
Failed junit tests	hadoop.hbase.client.TestAdmin2

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-894/1/artifact/out/Dockerfile
GITHUB PR	#894
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 0527a7129e19 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-894/out/precommit/personality/provided.sh
git revision	branch-1 / da9f6bf
Default Java	1.7.0_242
Multi-JDK versions	/usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242
findbugs	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-894/1/artifact/out/new-findbugs-hbase-server.html
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-894/1/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-894/1/testReport/
Max. process+thread count	4057 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-894/1/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 2 new or modified test files.
		_ branch-1 Compile Tests _
+1 💚	mvninstall	8m 45s	branch-1 passed
+1 💚	compile	0m 41s	branch-1 passed with JDK v1.8.0_232
+1 💚	compile	0m 44s	branch-1 passed with JDK v1.7.0_242
+1 💚	checkstyle	1m 33s	branch-1 passed
+1 💚	shadedjars	2m 51s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	branch-1 passed with JDK v1.8.0_232
+1 💚	javadoc	0m 42s	branch-1 passed with JDK v1.7.0_242
+0 🆗	spotbugs	2m 52s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	2m 49s	branch-1 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	1m 56s	the patch passed
+1 💚	compile	0m 38s	the patch passed with JDK v1.8.0_232
+1 💚	javac	0m 38s	the patch passed
+1 💚	compile	0m 44s	the patch passed with JDK v1.7.0_242
+1 💚	javac	0m 44s	the patch passed
+1 💚	checkstyle	1m 30s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	2m 46s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	5m 3s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚	javadoc	0m 30s	the patch passed with JDK v1.8.0_232
+1 💚	javadoc	0m 41s	the patch passed with JDK v1.7.0_242
+1 💚	findbugs	2m 52s	the patch passed
		_ Other Tests _
+1 💚	unit	128m 57s	hbase-server in the patch passed.
+1 💚	asflicense	0m 33s	The patch does not generate ASF License warnings.
		169m 3s

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-894/2/artifact/out/Dockerfile
GITHUB PR	#894
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux cfb517ec40df 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-894/out/precommit/personality/provided.sh
git revision	branch-1 / da9f6bf
Default Java	1.7.0_242
Multi-JDK versions	/usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-894/2/testReport/
Max. process+thread count	4056 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-894/2/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.