HBASE-21257 misspelled words.[occured -> occurred] by gangxueZhang · Pull Request #91 · apache/hbase

gangxueZhang · 2018-09-29T02:19:22Z

hi!
This PR does not affect the program function. It only modifies the misspelled words in the exception information and changes "occured" to "occurred".
Found in HBASE-21257

busbey · 2018-09-29T02:23:14Z

Hi!

Thanks for taking the time to put together this PR. The HBase project uses the HBASE tracker in ASF JIRA instance to review and apply work. Would you mind filing a request there that describes the problem and proposed solution?

Our contributor guide section includes instructions on how to attach a patch to your issue once it exists.

Thanks for your interest in improving Apache HBase!

gangxueZhang · 2018-10-18T03:29:27Z

hi!
This PR does not affect the program function. It only modifies the misspelled words in the exception information and changes "occured" to "occurred".
Found in jira :HBASE-21257

Apache9 · 2019-04-06T00:04:12Z

Hey @gangxueZhang the GitHub integration for HBase has been set up, could you please update the PR since there are conflicts?

Thanks.

Apache-HBase · 2019-04-06T04:33:34Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	6	#91 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem	Report/Notes
GITHUB PR	#91
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-91/1/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache9 · 2019-04-06T12:02:31Z

@gangxueZhang Please combine your commits into one commit? Thanks.

gangxueZhang · 2019-04-07T09:12:45Z

@Apache9 Hello, I am not very familiar with github now. Can you guide me how to merge these two commits? I will operate here. Thank you.

Apache9 · 2019-04-07T13:00:19Z

Just check out the newest master of hbase, and cherry-pick your old patch, resolve conflicts, then force push to your master, the PR here will be changed automatically.

Apache-HBase · 2019-04-07T13:40:58Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	5	#91 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem	Report/Notes
GITHUB PR	#91
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-91/2/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

gangxueZhang · 2019-04-07T13:55:50Z

@Apache9 Hey, I have done what you said, but I don't know if it is right, help me confirm it,please.

Apache9 · 2019-04-07T14:09:51Z

You have some merge commits in your own repo, which leads to conflicts. I suggest you record the commit id 'fcfa14e2f176d19e9ce984fe4687c3e1fd57e66f', and then reset to an earlier commit before the merge commits, and then sync with the master branch of apache/hbase again, and then cherry-pick the 'fcfa14e2f176d19e9ce984fe4687c3e1fd57e66f'. And last, do a force push your master branch.

Apache-HBase · 2019-04-07T22:41:38Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	6	#91 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem	Report/Notes
GITHUB PR	#91
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-91/3/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-04-08T18:20:51Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	5	#91 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem	Report/Notes
GITHUB PR	#91
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-91/4/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

# Conflicts: # hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessChecker.java

(cherry picked from commit c7ac518)

gangxueZhang · 2019-04-09T01:32:40Z

@Apache9 Hi, is this OK？ if not, can I close this PR and submit a new PR based on the latest version?

Apache-HBase · 2019-04-09T01:33:54Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	6	#91 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem	Report/Notes
GITHUB PR	#91
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-91/5/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache9 · 2019-04-09T01:37:43Z

Seems the robot is still not able to apply the patch.

@gangxueZhang Yes, you can close this one and open a new one, if it is easier for you.

Thanks.

gangxueZhang · 2019-04-13T14:24:45Z

@Apache9 Hey, this PR has been closed by me, and a new PR#146 has been created to replace it. If there is no problem, please merge the changes in PR#146.

…m checksum switching (apache#5660) (apache#91) Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit c28e285) Co-authored-by: Bryan Beaudreault <bbeaudreault@apache.org>

misspelled words.[occured -> occurred]
c7ac518

gangxueZhang changed the title ~~misspelled words.[occured -> occurred]~~HBASE-21257 misspelled words.[occured -> occurred]Oct 25, 2018

toyokazu03102478 approved these changes Nov 25, 2018
View reviewed changes

zhanggangxue added 2 commits April 9, 2019 09:17

Merge branch 'master' ofhttps://github.com/apache/hbase
81973e4
# Conflicts: # hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessChecker.java

misspelled words.[occured -> occurred]
dbcceea
(cherry picked from commit c7ac518)

gangxueZhang closed this Apr 13, 2019

gangxueZhang mentioned this pull request Apr 13, 2019
HBASE-21257 misspelled words.[occured -> occurred] #146
Merged

ndimiduk pushed a commit to ndimiduk/hbase that referenced this pull request May 16, 2024
Reuse some healthcheck code (apache#91)
6c01d85

Uh oh!

Conversation

gangxueZhang commented Sep 29, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

busbey commented Sep 29, 2018

Uh oh!

gangxueZhang commented Oct 18, 2018

Uh oh!

Apache9 commented Apr 6, 2019

Uh oh!

Apache-HBase commented Apr 6, 2019

Uh oh!

Apache9 commented Apr 6, 2019

Uh oh!

gangxueZhang commented Apr 7, 2019

Uh oh!

Apache9 commented Apr 7, 2019

Uh oh!

Apache-HBase commented Apr 7, 2019

Uh oh!

gangxueZhang commented Apr 7, 2019

Uh oh!

Apache9 commented Apr 7, 2019

Uh oh!

Apache-HBase commented Apr 7, 2019

Uh oh!

Apache-HBase commented Apr 8, 2019

Uh oh!

gangxueZhang commented Apr 9, 2019

Uh oh!

Apache-HBase commented Apr 9, 2019

Uh oh!

Apache9 commented Apr 9, 2019

Uh oh!

gangxueZhang commented Apr 13, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gangxueZhang commented Sep 29, 2018•
edited
Loading