HBASE-23578 [UI] Master UI shows long stack traces when table is broken by yamasakisua · Pull Request #951 · apache/hbase

yamasakisua · 2019-12-18T22:36:59Z

No description provided.

Apache-HBase · 2019-12-19T01:39:15Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1 💚	mvninstall	5m 53s	master passed
+1 💚	javadoc	0m 37s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 58s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 38s	the patch passed
		_ Other Tests _
+1 💚	unit	164m 26s	hbase-server in the patch passed.
+1 💚	asflicense	0m 35s	The patch does not generate ASF License warnings.
		178m 54s

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-951/1/artifact/out/Dockerfile
GITHUB PR	#951
Optional Tests	dupname asflicense javac javadoc unit
uname	Linux 5fb1d352edb8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-951/out/precommit/personality/provided.sh
git revision	master / `17e180e`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-951/1/testReport/
Max. process+thread count	4832 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-951/1/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani · 2019-12-30T14:09:36Z

 <% }
-} catch(Exception ex) {
+} catch(Exception ex) { %>
+ Unknown Regions


This is basically some issue with regions while iterating regDistribution. Is it good to display: Unknown issue with Regions instead?

Thanks for your comment.
I'll change the message to "Unknown issue with Regions"

xcangCRM · 2020-01-30T00:37:23Z

This LGTM.
Please fix the conflict. thank you @YamasakiSS

xcangCRM

please fix conflict

virajjasani · 2020-02-02T19:38:40Z

- %><%= StringEscapeUtils.escapeHtml4(element.toString()) %><%
+ %><%= StringEscapeUtils.escapeHtml4(element.toString() + "\n") %><%
 }
-} finally {


Removal of finally seems unintentional

Previous commit was conflicted in code of the finally section.
The HBASE-23653 removed the section and closed connection by changing hbase-server/src/test/java/org/apache/hadoop/hbase/ConnectionRule.java.
I thought I should keep compatibility with the HBASE-23653.
How should I modify the code intentionally?

Sure sounds good. Btw, QA run output says branch needs rebase with master. Could you please rebase one more time? Hopefully we should be able to merge after that.
Thanks

Thank you for comment. I rebased HBASE-23578 with master.

Apache-HBase · 2020-02-02T19:41:33Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 0s	Docker mode activated.
-1 ❌	patch	0m 5s	#951 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem	Report/Notes
GITHUB PR	#951
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-951/2/console
versions	git=2.17.1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani

+1

Apache-HBase · 2020-02-04T16:16:10Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1 💚	mvninstall	5m 39s	master passed
+1 💚	javadoc	0m 39s	master passed
-0 ⚠️	patch	6m 32s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 59s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	151m 20s	hbase-server in the patch passed.
+1 💚	asflicense	0m 39s	The patch does not generate ASF License warnings.
		165m 36s

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-951/3/artifact/out/Dockerfile
GITHUB PR	#951
Optional Tests	dupname asflicense javac javadoc unit
uname	Linux 7390e8a52c38 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-951/out/precommit/personality/provided.sh
git revision	master / `bb14bda`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-951/3/testReport/
Max. process+thread count	5123 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-951/3/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-05-22T20:33:39Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 4s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
-0 ⚠️	patch	0m 18s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
		_ Other Tests _
+1 💚	asflicense	0m 13s	The patch does not generate ASF License warnings.
		2m 17s

Subsystem	Report/Notes
Docker	Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-951/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#951
Optional Tests	dupname asflicense
uname	Linux 6c16796cbcae 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e1d7dc8`
Max. process+thread count	43 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-951/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-05-22T22:54:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 42s	master passed
+1 💚	javadoc	0m 38s	master passed
-0 ⚠️	patch	4m 33s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 21s	the patch passed
+1 💚	javadoc	0m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	132m 17s	hbase-server in the patch passed.
		142m 56s

Subsystem	Report/Notes
Docker	Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-951/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#951
Optional Tests	javac javadoc unit
uname	Linux 86e282019023 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e1d7dc8`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-951/1/testReport/
Max. process+thread count	4422 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-951/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-05-23T00:09:39Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 24s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 55s	master passed
-0 ⚠️	javadoc	0m 43s	hbase-server in master failed.
-0 ⚠️	patch	5m 48s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 43s	the patch passed
-0 ⚠️	javadoc	0m 42s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	unit	205m 21s	hbase-server in the patch passed.
		218m 18s

Subsystem	Report/Notes
Docker	Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-951/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#951
Optional Tests	javac javadoc unit
uname	Linux 7f7b57dff7e4 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e1d7dc8`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-951/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-951/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-951/1/testReport/
Max. process+thread count	3454 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-951/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-05-23T02:09:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 55s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
-0 ⚠️	patch	0m 24s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1 💚	whitespace	0m 1s	The patch has no whitespace issues.
		_ Other Tests _
+1 💚	asflicense	0m 16s	The patch does not generate ASF License warnings.
		3m 27s

Subsystem	Report/Notes
Docker	Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-951/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#951
Optional Tests	dupname asflicense
uname	Linux 1ef6d429cd82 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2b894dc`
Max. process+thread count	43 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-951/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-05-23T02:23:35Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 21s	master passed
+1 💚	javadoc	0m 37s	master passed
-0 ⚠️	patch	4m 11s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 27s	the patch passed
+1 💚	javadoc	0m 34s	the patch passed
		_ Other Tests _
-1 ❌	unit	6m 56s	hbase-server in the patch failed.
		16m 34s

Subsystem	Report/Notes
Docker	Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-951/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#951
Optional Tests	javac javadoc unit
uname	Linux 19d4681c1655 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2b894dc`
Default Java	1.8.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-951/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-951/2/testReport/
Max. process+thread count	1226 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-951/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-05-23T06:03:48Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 59s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 54s	master passed
-0 ⚠️	javadoc	0m 54s	hbase-server in master failed.
-0 ⚠️	patch	7m 0s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 37s	the patch passed
-0 ⚠️	javadoc	0m 48s	hbase-server in the patch failed.
		_ Other Tests _
-1 ❌	unit	216m 11s	hbase-server in the patch failed.
		233m 8s

Subsystem	Report/Notes
Docker	Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-951/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#951
Optional Tests	javac javadoc unit
uname	Linux 94037d04464d 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2b894dc`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-951/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-951/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-951/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-951/2/testReport/
Max. process+thread count	2980 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-951/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2021-03-04T10:10:00Z

Opened a new PR against master.

For compaction state, now it is gotten from master directly and there is no exception, so we do not need the fix any more.

#3014

[UI] Master UI shows long stack traces when table is broken
d449111

yamasakisua changed the title ~~[UI] Master UI shows long stack traces when table is broken~~HBASE-23578 [UI] Master UI shows long stack traces when table is brokenDec 18, 2019

virajjasani reviewed Dec 30, 2019
View reviewed changes

xcangCRM self-requested a review January 30, 2020 00:37

xcangCRM reviewed Jan 30, 2020
View reviewed changes

YamasakiSS added 3 commits February 3, 2020 03:45

fix conflict by delete finally section
ee021f0

remove extra closing tag
4fe61b9

Merge branch 'local-HBASE-23578'
3fe3ef3

virajjasani reviewed Feb 2, 2020
View reviewed changes

Merge remote-tracking branch 'upstream/master'
cb122e8

virajjasani approved these changes Feb 4, 2020
View reviewed changes

Apache9 closed this Mar 4, 2021

Uh oh!

Conversation

yamasakisua commented Dec 18, 2019

Uh oh!

Apache-HBase commented Dec 19, 2019

Uh oh!

virajjasaniDec 30, 2019

Choose a reason for hiding this comment

Uh oh!

yamasakisuaJan 31, 2020

Choose a reason for hiding this comment

Uh oh!

xcangCRM commented Jan 30, 2020

Uh oh!

xcangCRM left a comment

Choose a reason for hiding this comment

Uh oh!

virajjasaniFeb 2, 2020

Choose a reason for hiding this comment

Uh oh!

yamasakisuaFeb 2, 2020

Choose a reason for hiding this comment

Uh oh!

virajjasaniFeb 3, 2020

Choose a reason for hiding this comment

Uh oh!

yamasakisuaFeb 4, 2020

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Feb 2, 2020

Uh oh!

virajjasani left a comment

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Feb 4, 2020

Uh oh!

Apache-HBase commented May 22, 2020

Uh oh!

Apache-HBase commented May 22, 2020

Uh oh!

Apache-HBase commented May 23, 2020

Uh oh!

Apache-HBase commented May 23, 2020

Uh oh!

Apache-HBase commented May 23, 2020

Uh oh!

Apache-HBase commented May 23, 2020

Uh oh!

Apache9 commented Mar 4, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants