Skip to content

HBASE-23635 Reduced number of Checkstyle violations in hbase-mapreduce - #981

Merged
HorizonNet merged 1 commit into
apache:masterfrom
ultratendency:HBASE-23635
Jan 3, 2020
Merged

HBASE-23635 Reduced number of Checkstyle violations in hbase-mapreduce#981
HorizonNet merged 1 commit into
apache:masterfrom
ultratendency:HBASE-23635

Conversation

@HorizonNet

Copy link
Copy Markdown
Contributor

No description provided.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 6sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 10 new or modified test files.
_ master Compile Tests _
+1 💚mvninstall5m 57smaster passed
+1 💚compile0m 25smaster passed
+1 💚checkstyle0m 21smaster passed
+1 💚shadedjars5m 1sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 18smaster passed
+0 🆗spotbugs0m 51sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs0m 50smaster passed
_ Patch Compile Tests _
+1 💚mvninstall5m 27sthe patch passed
+1 💚compile0m 26sthe patch passed
+1 💚javac0m 26sthe patch passed
+1 💚checkstyle0m 19shbase-mapreduce: The patch generated 0 new + 0 unchanged - 35 fixed = 0 total (was 35)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedjars5m 5spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck17m 18sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚javadoc0m 17sthe patch passed
+1 💚findbugs0m 56sthe patch passed
_ Other Tests _
+1 💚unit16m 46shbase-mapreduce in the patch passed.
+1 💚asflicense0m 19sThe patch does not generate ASF License warnings.
67m 46s
SubsystemReport/Notes
DockerClient=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-981/1/artifact/out/Dockerfile
GITHUB PR#981
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 53360e04e69d 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-981/out/precommit/personality/provided.sh
git revisionmaster / 85ecdd1
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-981/1/testReport/
Max. process+thread count5262 (vs. ulimit of 10000)
modulesC: hbase-mapreduce U: hbase-mapreduce
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-981/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@virajjasanivirajjasani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@saintstacksaintstack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed. Looks great.

@HorizonNet
HorizonNet merged commit ab97665 into apache:masterJan 3, 2020
@HorizonNet
HorizonNet deleted the HBASE-23635 branch January 3, 2020 23:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@HorizonNet@Apache-HBase@saintstack@virajjasani