Skip to content

HBASE-23642 Reintroduce ReplicationUtils.contains as deprecated - #983

Merged
petersomogyi merged 1 commit into
apache:branch-2from
petersomogyi:HBASE-23642
Jan 4, 2020
Merged

HBASE-23642 Reintroduce ReplicationUtils.contains as deprecated#983
petersomogyi merged 1 commit into
apache:branch-2from
petersomogyi:HBASE-23642

Conversation

@petersomogyi

Copy link
Copy Markdown
Contributor

No description provided.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 7sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-0 ⚠️test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2 Compile Tests _
+1 💚mvninstall7m 27sbranch-2 passed
+1 💚compile0m 22sbranch-2 passed
+1 💚checkstyle0m 17sbranch-2 passed
+1 💚shadedjars5m 32sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 18sbranch-2 passed
+0 🆗spotbugs0m 46sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs0m 42sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall6m 57sthe patch passed
+1 💚compile0m 22sthe patch passed
+1 💚javac0m 22sthe patch passed
+1 💚checkstyle0m 15sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedjars5m 46spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck21m 10sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚javadoc0m 14sthe patch passed
+1 💚findbugs0m 35sthe patch passed
_ Other Tests _
+1 💚unit0m 38shbase-replication in the patch passed.
+1 💚asflicense0m 12sThe patch does not generate ASF License warnings.
60m 3s
SubsystemReport/Notes
DockerClient=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-983/1/artifact/out/Dockerfile
GITHUB PR#983
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 614ff93c40f9 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-983/out/precommit/personality/provided.sh
git revisionbranch-2 / 26b1695
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-983/1/testReport/
Max. process+thread count172 (vs. ulimit of 10000)
modulesC: hbase-replication U: hbase-replication
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-983/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@wchevreuilwchevreuil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@virajjasanivirajjasani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@petersomogyi
petersomogyi merged commit 3f646d8 into apache:branch-2Jan 4, 2020
@petersomogyi
petersomogyi deleted the HBASE-23642 branch January 4, 2020 11:14
asfgit pushed a commit that referenced this pull request Jan 4, 2020
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: stack <stack@apache.org>
Signed-off-by: Jan Hentschel <janh@apache.org>
asfgit pushed a commit that referenced this pull request Jan 4, 2020
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: stack <stack@apache.org>
Signed-off-by: Jan Hentschel <janh@apache.org>
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
…he#983)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: stack <stack@apache.org>
Signed-off-by: Jan Hentschel <janh@apache.org>
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
…he#983)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: stack <stack@apache.org>
Signed-off-by: Jan Hentschel <janh@apache.org>
(cherry picked from commit 89b6453)
Change-Id: I46a89657e1831a3cb70df0aa46282407c1248795
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@petersomogyi@Apache-HBase@saintstack@HorizonNet@wchevreuil@virajjasani