Made DemoClient python 3.0 compatible .. · Pull Request #988 · apache/hbase

ghost · 2020-01-04T10:40:00Z

Issue is the DemoClient.py is not updated for python 3.X. Python 2.X support has ended. Updating this to 3.0. Please see
https://issues.apache.org/jira/browse/HBASE-23644

Issue is the DemoClient.py is not updated for python 3.X. Python 2.X support has ended. Updating this to 3.0. Please see https://issues.apache.org/jira/browse/HBASE-23644

Apache-HBase · 2020-01-04T11:00:04Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1 💚	mvninstall	5m 30s	master passed
-1 ❌	pylint	0m 1s	Error running pylint. Please check pylint stderr files.
+1 💚	javadoc	0m 22s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 56s	the patch passed
-1 ❌	pylint	0m 2s	Error running pylint. Please check pylint stderr files.
+1 💚	pylint	0m 2s	There were no new pylint issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 19s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 40s	hbase-examples in the patch passed.
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		14m 50s

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-988/1/artifact/out/Dockerfile
GITHUB PR	#988
Optional Tests	dupname asflicense javac javadoc unit pylint
uname	Linux 746236977ed4 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-988/out/precommit/personality/provided.sh
git revision	master / `ab97665`
Default Java	1.8.0_181
pylint	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-988/1/artifact/out/branch-pylint-stderr.txt
pylint	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-988/1/artifact/out/patch-pylint-stderr.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-988/1/testReport/
Max. process+thread count	2171 (vs. ulimit of 10000)
modules	C: hbase-examples U: hbase-examples
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-988/1/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) pylint=1.6.5
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Closed issue https://issues.apache.org/jira/browse/HBASE-23644. Updated DemoClient.py to work with python 3.0, thrift compiler 0.13 and python thrift 0.13 package which are the latest. Please note even with thrift-0.9.3 DemoClient.py was not compatible with python 3.X.

Apache-HBase · 2020-01-05T01:05:49Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1 💚	mvninstall	5m 36s	master passed
-1 ❌	pylint	0m 0s	Error running pylint. Please check pylint stderr files.
+1 💚	javadoc	0m 22s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 54s	the patch passed
-1 ❌	pylint	0m 0s	Error running pylint. Please check pylint stderr files.
+1 💚	pylint	0m 0s	There were no new pylint issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 21s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 40s	hbase-examples in the patch passed.
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		15m 40s

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-988/2/artifact/out/Dockerfile
GITHUB PR	#988
Optional Tests	dupname asflicense javac javadoc unit pylint
uname	Linux b2f68058fb7d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-988/out/precommit/personality/provided.sh
git revision	master / `ab97665`
Default Java	1.8.0_181
pylint	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-988/2/artifact/out/branch-pylint-stderr.txt
pylint	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-988/2/artifact/out/patch-pylint-stderr.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-988/2/testReport/
Max. process+thread count	2179 (vs. ulimit of 10000)
modules	C: hbase-examples U: hbase-examples
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-988/2/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) pylint=1.6.5
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

busbey · 2020-01-06T15:34:03Z

Does this still work with python 2? Or is it python 3 only?

I'd be fine with the master branch being python 3 only if we can make branch-2 python 2 and python 3. This could be done with mutliple examples if needed.

ghost · 2020-01-10T23:59:57Z

The file DemoClient.py that I made a new pull request in https://github.com/apache/hbase works with python 3.X. I'm not sure what the issue with github is, it has broken heart with -1 on top with some error from pylint. I'm not sure what I need to do to get it fixed. If you can let me know, I can get it committed.

…

On Mon, Jan 6, 2020 at 9:34 AM Sean Busbey ***@***.***> wrote: Does this still work with python 2? Or is it python 3 only? I'd be fine with the master branch being python 3 only if we can make branch-2 python 2 and python 3. This could be done with mutliple examples if needed. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#988?email_source=notifications&email_token=ALFG3HQ2EC6MW4OXB3F26B3Q4NFOZA5CNFSM4KCVOL62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIFZPOQ#issuecomment-571185082>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALFG3HQV4E55L6A4AERW7J3Q4NFOZANCNFSM4KCVOL6Q> .

HorizonNet · 2020-01-24T15:02:39Z

@pytalkweb We're running pylint from the build. Could you please check your changes with pylint?

ghost · 2020-01-26T05:39:03Z

It seems problem might be with script that runs pylint as stderr.txt says there is no such option —score. Please see below. Usage: pylint [options] module_or_package Check that a module satisfies a coding standard (and more !). pylint --help Display this help message and exit. pylint --help-msg <msg-id>[,<msg-id>] Display help messages about given message identifiers and exit. pylint: error: no such option: --score Regards, Madhu

…

On Fri, Jan 24, 2020 at 9:02 AM Jan Hentschel ***@***.***> wrote: @pytalkweb <https://github.com/pytalkweb> We're running pylint from the build. Could you please check your changes with pylint? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#988?email_source=notifications&email_token=ALFG3HQ4HGAZODJLFNTTIKLQ7L7JBA5CNFSM4KCVOL62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ3B7AI#issuecomment-578166657>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALFG3HTCLLCDIFAWXGCCAWLQ7L7JBANCNFSM4KCVOL6Q> .

HorizonNet · 2020-01-26T12:32:35Z

The pylint problems could be the same as in #1088.

busbey · 2020-01-27T17:17:35Z

Just to reiterate here, I would be fine with this being Python 3 only in the master branch, but to do that we need an option to maintain python 2 for branch-2 / branch-1 and hopefully opt-in to python 3 on branch-2 at least.

saintstack · 2020-05-04T21:32:05Z

Will close out unless update inside next week. Thanks.

Apache-HBase · 2020-05-22T21:14:11Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 43s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
-0 ⚠️	pylint	0m 5s	The patch generated 11 new + 0 unchanged - 1 fixed = 11 total (was 1)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
		_ Other Tests _
+1 💚	asflicense	0m 13s	The patch does not generate ASF License warnings.
		3m 6s

Subsystem	Report/Notes
Docker	Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-988/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#988
Optional Tests	dupname asflicense pylint
uname	Linux 16bf6196dd7a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e1d7dc8`
pylint	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-988/1/artifact/yetus-general-check/output/diff-patch-pylint.txt
Max. process+thread count	47 (vs. ulimit of 12500)
modules	C: hbase-examples U: hbase-examples
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-988/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) pylint=2.4.4
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-05-22T21:23:38Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 9s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 2s	master passed
+1 💚	javadoc	0m 21s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 46s	the patch passed
+1 💚	javadoc	0m 20s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 7s	hbase-examples in the patch passed.
		12m 34s

Subsystem	Report/Notes
Docker	Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-988/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#988
Optional Tests	javac javadoc unit
uname	Linux 0d43326f15f5 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e1d7dc8`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-988/1/testReport/
Max. process+thread count	1886 (vs. ulimit of 12500)
modules	C: hbase-examples U: hbase-examples
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-988/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-05-22T21:28:51Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	4m 13s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 47s	master passed
-0 ⚠️	javadoc	0m 20s	hbase-examples in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 4s	the patch passed
-0 ⚠️	javadoc	0m 21s	hbase-examples in the patch failed.
		_ Other Tests _
+1 💚	unit	2m 4s	hbase-examples in the patch passed.
		17m 44s

Subsystem	Report/Notes
Docker	Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-988/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#988
Optional Tests	javac javadoc unit
uname	Linux 37d3adfaeda5 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `0ce85fe`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-988/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-examples.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-988/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-examples.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-988/1/testReport/
Max. process+thread count	1488 (vs. ulimit of 12500)
modules	C: hbase-examples U: hbase-examples
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-988/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

saintstack · 2020-10-06T00:41:27Z

Closing abandoned PR

Made DemoClient python 3.0 compatible ..
5184650
Issue is the DemoClient.py is not updated for python 3.X. Python 2.X support has ended. Updating this to 3.0. Please see https://issues.apache.org/jira/browse/HBASE-23644

saintstack closed this Oct 6, 2020

Navigation Menu

Uh oh!

Made DemoClient python 3.0 compatible .. - #988

Made DemoClient python 3.0 compatible ..#988
ghost wants to merge 2 commits into
masterfrom
unknown repository

ghost commented Jan 4, 2020

Uh oh!

Apache-HBase commented Jan 4, 2020

Uh oh!

Apache-HBase commented Jan 5, 2020

Uh oh!

busbey commented Jan 6, 2020

Uh oh!

ghost commented Jan 10, 2020 via email

Uh oh!

HorizonNet commented Jan 24, 2020

Uh oh!

ghost commented Jan 26, 2020 via email

Uh oh!

HorizonNet commented Jan 26, 2020

Uh oh!

busbey commented Jan 27, 2020

Uh oh!

saintstack commented May 4, 2020

Uh oh!

Apache-HBase commented May 22, 2020

Uh oh!

Apache-HBase commented May 22, 2020

Uh oh!

Apache-HBase commented May 22, 2020

Uh oh!

saintstack commented Oct 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

ghost commented Jan 4, 2020

Uh oh!

Apache-HBase commented Jan 4, 2020

Uh oh!

Apache-HBase commented Jan 5, 2020

Uh oh!

busbey commented Jan 6, 2020

Uh oh!

ghost commented Jan 10, 2020 via email

Uh oh!

HorizonNet commented Jan 24, 2020

Uh oh!

ghost commented Jan 26, 2020 via email

Uh oh!

HorizonNet commented Jan 26, 2020

Uh oh!

busbey commented Jan 27, 2020

Uh oh!

saintstack commented May 4, 2020

Uh oh!

Apache-HBase commented May 22, 2020

Uh oh!

Apache-HBase commented May 22, 2020

Uh oh!

Apache-HBase commented May 22, 2020

Uh oh!

saintstack commented Oct 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants