Uh oh!
There was an error while loading. Please reload this page.
HIVE-24331: Add Jenkinsfile for branch-3.1 - #1626
Conversation
sunchao
commented
Oct 30, 2020
seems the |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you so much, @sunchao !
dongjoon-hyun
commented
Oct 30, 2020
Interesting. It seems that we need more patches. |
sunchao
commented
Oct 30, 2020
I think these failures are not related to the PR - at least the PR itself gives us a baseline for the test results. |
sunchao
commented
Oct 30, 2020
cc @kgyrtkirk could you take a look? thanks. |
kgyrtkirk
commented
Nov 2, 2020
thank you @sunchao for working on this! these failures were most likely there before as well. I haven't noticed anything problematic (with the test execution stuff) |
dongjoon-hyun
commented
Nov 2, 2020
Thank you, @kgyrtkirk and @sunchao . |
sunchao
commented
Nov 2, 2020
Thanks @kgyrtkirk . I'll backport HIVE-23323 and HIVE-19170 separately to the branch-3.1 to retain a clean commit history, and then create a new PR with just the jenkins file change and merge it. |
3b3a766 to
9e67f19Comparesunchao
commented
Nov 2, 2020
Merged. Thanks @kgyrtkirk for the review. |
dongjoon-hyun
commented
Nov 2, 2020
Thank you so much! |
What changes were proposed in this pull request?
Two changes combined in this PR:
Why are the changes needed?
Without a Jenkinsfile we won't trigger CI for new PRs against the branch-3.1. This allows ppl to test their code.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests