Skip to content

HIVE-25497: Moving to ORC to 1.7.2 - #2853

Closed
pgaref wants to merge 2 commits into
apache:masterfrom
pgaref:HIVE-25497
Closed

HIVE-25497: Moving to ORC to 1.7.2#2853
pgaref wants to merge 2 commits into
apache:masterfrom
pgaref:HIVE-25497

Conversation

@pgaref

@pgarefpgaref commented Dec 8, 2021

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Bumping to 1.7.1.
LLAP EncodedTreeReaderFactory is implementing its own TreeReaderFactory -- initially we are going to avoid LAZY IO here as everything is kept in memory.

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

… a hard implementing its own TreeReaderFactory but initially we are going to avoid LAZY IO here as everything is kept in memory.
Change-Id: I210d820efac97e2146dfebfb7d10942980124350
Change-Id: I0aaf22212270daf93dffdd0969e995da5a61b587
@dongjoon-hyun

Copy link
Copy Markdown
Member

Hi, @pgaref .

  • What is the current status of this PR?
  • Could you update the PR title to 1.7.2?

cc @williamhyun

@pgarefpgaref changed the title HIVE-25497: Moving to ORC to 1.7.1HIVE-25497: Moving to ORC to 1.7.2Jan 12, 2022
@pgaref

Copy link
Copy Markdown
ContributorAuthor

Hi, @pgaref .

  • What is the current status of this PR?
  • Could you update the PR title to 1.7.2?

cc @williamhyun

Hey @dongjoon-hyun -- thanks for checking!
This PR is aiming to bump to orc 1.7.2 indeed -- updated title.
Regarding the status, had to refactor EncodedTreeReaderFactory in order to use the latest internal API but there are still a bunch of test failures. Some of them are related to file stats that can be regenerated but I also found some OutOfBoundsException showing that some file seeking is not handled properly.

@dongjoon-hyun

Copy link
Copy Markdown
Member

Thank you for the info, @pgaref .

@github-actions

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.

@slachiewicz

Copy link
Copy Markdown
Member

@kgyrtkirk@pgaref could reopen PR and review again?

@dongjoon-hyun

Copy link
Copy Markdown
Member

+1 for @slachiewicz comment. The latest one is Apache ORC 1.7.4. We can re-try with 1.7.4.

@dongjoon-hyun

Copy link
Copy Markdown
Member

And, FYI, cc @williamhyun and @stiga-huang

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@pgaref@dongjoon-hyun@slachiewicz@kgyrtkirk