Skip to content

HIVE-24483: Bump protobuf version to 3.7.1 (aarch64 support). - #3498

Merged
ayushtkn merged 9 commits into
apache:masterfrom
ayushtkn:HIVE-24483
Aug 11, 2022
Merged

HIVE-24483: Bump protobuf version to 3.7.1 (aarch64 support).#3498
ayushtkn merged 9 commits into
apache:masterfrom
ayushtkn:HIVE-24483

Conversation

@ayushtkn

@ayushtknayushtkn commented Aug 3, 2022

Copy link
Copy Markdown
Member

Exploratory Sate: See what all breaks

@Noremac201

Noremac201 commented Aug 3, 2022

Copy link
Copy Markdown
Contributor

Won't standalone-metastore/pom.xml also need to be updated?

@ayushtkn

ayushtkn commented Aug 3, 2022

Copy link
Copy Markdown
MemberAuthor

yep, @Noremac201 I updated there and there were some explicit changes for Aarch because of lower version of protobuf, have updated that.
Saw 2 Hbase related failure in the last build, may be upgrading Hbase version should solve them, will check post the next build result

@ayushtknayushtkn mentioned this pull request Aug 4, 2022
Closed
@ayushtkn

ayushtkn commented Aug 4, 2022

Copy link
Copy Markdown
MemberAuthor

Got a green build with 3.7.1 version(the red is due to oracle init failing), which is same as with one present in hadoop. Attempted to upgraded to 3.21.1 which is the latest.
Tried building on AArch-64 as well and the build was successful

@slachiewicz

slachiewicz commented Aug 4, 2022

Copy link
Copy Markdown
Member

You shout also regenerate code running with Protobuf profile see #3500

@github-actions
github-actionsBot requested a review from pgarefAugust 4, 2022 15:43
@ayushtkn
ayushtkn requested a review from zabetakAugust 5, 2022 06:50
@ayushtkn

ayushtkn commented Aug 5, 2022

Copy link
Copy Markdown
MemberAuthor

Build is green. Tried compiling on OS-X-Aarch64 and I was able to get a successful mvn clean install -DskipTests without any hacks or tweaks.

Awaiting reviews now. :-)

zabetak
zabetak reviewed Aug 5, 2022
View reviewed changes
Comment threadstandalone-metastore/metastore-common/pom.xml Outdated
Comment threadhbase-handler/src/java/org/apache/hadoop/hive/hbase/ResultWritable.java
Comment threadhbase-handler/src/java/org/apache/hadoop/hive/hbase/ResultWritable.java
Comment threaddata/files/datasets/src_hbase/load.hive.sql
@ayushtkn
ayushtkn requested a review from zabetakAugust 9, 2022 20:16
zabetak
zabetak approved these changes Aug 10, 2022
View reviewed changes

@zabetakzabetak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ayushtkn
ayushtkn merged commit 18501dd into apache:masterAug 11, 2022
DongWei-4 pushed a commit to DongWei-4/hive that referenced this pull request Oct 28, 2022
@ayushtkn@DongWei-4
HIVE-24483: aarch64 Support: Bump protobuf version to 3.21.4 (apache#…
b8562c7
…3498). (Ayush Saxena, reviewed by Stamatis Zampetakis and Sylwester Lachiewicz)
dengzhhu653 pushed a commit to dengzhhu653/hive that referenced this pull request Dec 15, 2022
@ayushtkn@dengzhhu653
HIVE-24483: aarch64 Support: Bump protobuf version to 3.21.4 (apache#…
5ef4fc5
…3498). (Ayush Saxena, reviewed by Stamatis Zampetakis and Sylwester Lachiewicz)
prabhjyotsingh added a commit to acceldata-io/hive that referenced this pull request Oct 1, 2024
@prabhjyotsingh
Revert "HIVE-24483: aarch64 Support: Bump protobuf version to 3.21.4 (a…
fc96239
…pache#3498). (Ayush Saxena, reviewed by Stamatis Zampetakis and Sylwester Lachiewicz)"
This reverts commit 18501dd.
senthh pushed a commit to acceldata-io/hive that referenced this pull request Jun 16, 2026
@ayushtkn@senthh
OSV-17493|HIVE-24483: aarch64 Support: Bump protobuf version to 3.21.4 (
72c1a1d
apache#3498). (Ayush Saxena, reviewed by Stamatis Zampetakis and Sylwester Lachiewicz)
(cherry picked from commit 18501dd)
senthh added a commit to acceldata-io/hive that referenced this pull request Jun 17, 2026
@senthh@zratkai@ayushtkn
OSV-17493 - CVE - Upgrading orc version to fixCVE-2024-36114(#168)
5c2cb92
* OSV-17493|HIVE-26809 Upgrade ORC to 1.8.3 (apache#4121) (Zoltan Ratkai reviewed by Laszlo Bodor)
(cherry picked from commit e397acd)
* OSV-17493|HIVE-24483: aarch64 Support: Bump protobuf version to 3.21.4 (apache#3498). (Ayush Saxena, reviewed by Stamatis Zampetakis and Sylwester Lachiewicz)
(cherry picked from commit 18501dd)
* OSV-17493|HIVE-27686 ORC upgraded to 1.8.5. (apache#4690) (Zoltan Ratkai reviewed by Laszlo Bodor)
(cherry picked from commit 5d58a21)
---------
Co-authored-by: Zoltan Ratkai <117656751+zratkai@users.noreply.github.com>
Co-authored-by: Ayush Saxena <ayushsaxena@apache.org>
prabhjyotsingh added a commit to acceldata-io/hive that referenced this pull request Jul 6, 2026
@prabhjyotsingh
Revert "HIVE-24483: aarch64 Support: Bump protobuf version to 3.21.4 (a…
8daea78
…pache#3498). (Ayush Saxena, reviewed by Stamatis Zampetakis and Sylwester Lachiewicz)"
This reverts commit 18501dd.
prabhjyotsingh added a commit to acceldata-io/hive that referenced this pull request Jul 6, 2026
@prabhjyotsingh
Revert "HIVE-24483: aarch64 Support: Bump protobuf version to 3.21.4 (a…
43a13fa
…pache#3498). (Ayush Saxena, reviewed by Stamatis Zampetakis and Sylwester Lachiewicz)"
This reverts commit 18501dd.
prabhjyotsingh added a commit to acceldata-io/hive that referenced this pull request Jul 7, 2026
@prabhjyotsingh
ODP-7120: Revert "HIVE-24483: aarch64 Support: Bump protobuf version …
27f73e9
…to 3.21.4 (apache#3498). (Ayush Saxena, reviewed by Stamatis Zampetakis and Sylwester Lachiewicz)"
This reverts commit 18501dd.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zabetakzabetakzabetak approved these changes
@pgarefpgarefAwaiting requested review from pgaref
@abstractdogabstractdogAwaiting requested review from abstractdog
+1 more reviewer
@slachiewiczslachiewiczslachiewicz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tests passed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ayushtkn@Noremac201@slachiewicz@zabetak@kgyrtkirk