Uh oh!
There was an error while loading. Please reload this page.
HIVE-27234: Iceberg: CREATE BRANCH SQL implementation - #4216
Conversation
d7db26d to
59e762eCompareuhhhhh! This is super cool idea! I want it! Actually with this it is possible to play on dataset without any risk. I love it! I want it! Documents about it: This is my new favorite PR (After the Docker support) |
Didn't check the code, But it was something I was also reading coincidently 2-3 hours before only :) The main thing to chase is not creating a branch. But to insert into those branches. @zhangbutao We should chase that once we have the create in. Will review this in a day or two along with Denys. :) Just FYI. I think Iceberg has options to create Tags as well now, and an option to do cherry-pick to branches as well. They are gonna release it for spark in 1.12.0 Good to have stuff!!! Was reading here: |
aturoczy
commented
Apr 19, 2023
Tags!!!! 😍 |
aturoczy
commented
Apr 19, 2023
Uh oh!
There was an error while loading. Please reload this page.
@TuroczyX @ayushtkn yes, branch and tag are important feats in iceberg 1.2.0. I have created a umbrella ticket https://issues.apache.org/jira/browse/HIVE-27233 to track the new feats about branch&tag.
I absolutely agree. I am exploring how to achieve this in hive. Next maybe we shoud consider upgrade iceberg to latest version 1.2.1. In addition, we can refer to this PR apache/iceberg#6965 to implement the sql syntax for |
zhangbutao
commented
Apr 20, 2023
#4252 Upgrade iceberg to 1.2.1 in order to better integrate branch&tag features. |
aturoczy
commented
Apr 20, 2023
yes, let's upgrade the iceberg version |
Uh oh!
There was an error while loading. Please reload this page.
deniskuzZ
left a comment
There was a problem hiding this comment.
Thanks for the path @zhangbutao! LGTM, some minor. comments, please take a look once you have a chance. Thank you!
Uh oh!
There was an error while loading. Please reload this page.
deniskuzZ
left a comment
There was a problem hiding this comment.
LGTM +1 (1 minor comment), pending tests
zhangbutao
commented
May 11, 2023
Git rebase to fix code conflicts. |
Kudos, SonarCloud Quality Gate passed! |
zhangbutao
commented
May 15, 2023
@deniskuzZ@ayushtkn Can we merge this PR first? Thanks. |










What changes were proposed in this pull request?
This PR refers to spark-sql about iceberg branch ddl implementation apache/iceberg#6617
If someone has different opinions about the sql syntax of branch, we can discuss here.
Why are the changes needed?
Personally, branch is more useful than snapshot in iceberg, and it is more friendly to users. We can use branch do lots of meaningfull work.
Does this PR introduce any user-facing change?
Added a new sql syntax and hive users can create iceberg branch using the sql.
How was this patch tested?
UT