Uh oh!
There was an error while loading. Please reload this page.
Hms standalone rest server with Spring Boot - #6327
Conversation
2e24788 to
196fd31ComparedeniskuzZ
commented
Feb 20, 2026
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| LOG.info("=== Test: Health Check ==="); | ||
| String healthUrl = "http://localhost:" + restCatalogServer.getPort() + "/health"; | ||
| public void testPrometheusMetrics() throws Exception { |
There was a problem hiding this comment.
do we use spring actuator? nice :)
Uh oh!
There was an error while loading. Please reload this page.
to support OAuth / JWT Authentication don't we need SecurityConfig? cc @okumin |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| System.setProperty(ConfVars.CATALOG_SERVLET_PORT.getVarname(), String.valueOf(port)); | ||
| } | ||
| StandaloneRESTCatalogServer server = new StandaloneRESTCatalogServer(conf); |
There was a problem hiding this comment.
Spring Boot should manage the lifecycle of your application class. Typically you don't manually instantiate your @SpringBootApplication class. see above snippet
deniskuzZ
left a comment
There was a problem hiding this comment.
added few comments, rest LGTM
adc0bc2 to
8c42e77CompareUh oh!
There was an error while loading. Please reload this page.
8c42e77 to
8886bd2CompareUh oh!
There was an error while loading. Please reload this page.



What changes were proposed in this pull request?
The Standalone REST Catalog Server is reimplemented to use Spring Boot instead of plain Java:
Standalone packaging – Adds a spring-boot-maven-plugin “exec” JAR for running the server as a standalone process.
Why are the changes needed?
Spring Boot improves how the Standalone REST Catalog Server is run and operated:
Does this PR introduce any user-facing change?
If the standalone REST Catalog server is deployed in Kubernetes:
-- Liveness: httpGet: /actuator/health/liveness
-- Readiness: httpGet: /actuator/health/readiness
How was this patch tested?
Integration tests in
TestStandaloneRESTCatalogServerandTestStandaloneRESTCatalogServerJwtAuthrun the Spring Boot standalone HMS REST catalog server and verify liveness/readiness probes, Prometheus metrics, REST catalog operations, and JWT auth with Keycloak (Testcontainers).