Skip to content

RFC 7639 ALPN - #731

Open
arturobernalg wants to merge 1 commit into
apache:masterfrom
arturobernalg:rfc7639
Open

RFC 7639 ALPN #731
arturobernalg wants to merge 1 commit into
apache:masterfrom
arturobernalg:rfc7639

Conversation

@arturobernalg

@arturobernalgarturobernalg commented Oct 6, 2025

Copy link
Copy Markdown
Member

Add ConnectAlpnProvider and inject ALPN header in ConnectExec/AsyncConnectExec. Provide builder hooks for fixed list or provider-driven values.

@arturobernalg
arturobernalgforce-pushed the rfc7639 branch 2 times, most recently from 42fd028 to 6140646CompareOctober 15, 2025 17:45
@arturobernalg
arturobernalg marked this pull request as ready for review October 15, 2025 17:45
@arturobernalg
arturobernalg marked this pull request as draft October 15, 2025 18:33
@arturobernalg
arturobernalg marked this pull request as ready for review October 15, 2025 18:43
@ok2c

ok2c commented Nov 29, 2025

Copy link
Copy Markdown
Member

@arturobernalg Could you please rebase this change-set?

@arturobernalg
arturobernalgforce-pushed the rfc7639 branch 2 times, most recently from cc58cd1 to 208b565CompareDecember 20, 2025 12:20
@arturobernalg

arturobernalg commented Dec 20, 2025

Copy link
Copy Markdown
MemberAuthor

@arturobernalg Could you please rebase this change-set?

@ok2c done.

ok2c
ok2c reviewed Jan 11, 2026
View reviewed changes
Comment threadhttpclient5/src/main/java/org/apache/hc/client5/http/impl/AlpnHeaderSupport.java Outdated
ok2c
ok2c reviewed Jan 11, 2026
View reviewed changes
Comment threadhttpclient5/src/main/java/org/apache/hc/client5/http/impl/AlpnHeaderSupport.java Outdated
ok2c
ok2c reviewed Jan 11, 2026
View reviewed changes
Comment threadhttpclient5/src/main/java/org/apache/hc/client5/http/impl/AlpnHeaderSupport.java Outdated
ok2c
ok2c reviewed Jan 11, 2026
View reviewed changes
Comment threadhttpclient5/src/main/java/org/apache/hc/client5/http/impl/AlpnHeaderSupport.java Outdated
@arturobernalg
arturobernalgforce-pushed the rfc7639 branch 2 times, most recently from a178fe7 to e343841CompareJanuary 12, 2026 09:57
ok2c
ok2c reviewed Jan 12, 2026
View reviewed changes
Comment threadhttpclient5/src/main/java/org/apache/hc/client5/http/impl/AlpnHeaderSupport.java Outdated
Comment threadhttpclient5/src/main/java/org/apache/hc/client5/http/impl/AlpnHeaderSupport.java
Comment threadhttpclient5/src/main/java/org/apache/hc/client5/http/impl/AlpnHeaderSupport.java Outdated
@arturobernalg
arturobernalgforce-pushed the rfc7639 branch 2 times, most recently from 249924c to bfb72b3CompareJanuary 12, 2026 15:17
ok2c
ok2c reviewed Apr 3, 2026
View reviewed changes
Comment threadhttpclient5/src/main/java/org/apache/hc/client5/http/impl/async/HttpAsyncClientBuilder.java Outdated
@ok2c

ok2c commented May 31, 2026

Copy link
Copy Markdown
Member

@arturobernalg This change can still make it into 5.7 if you are willing to invest time into it.

@arturobernalg
arturobernalgforce-pushed the rfc7639 branch 2 times, most recently from 36079e1 to 46a533eCompareJune 19, 2026 11:57
@arturobernalg
arturobernalg requested a review from ok2cJune 19, 2026 12:12
@arturobernalg

arturobernalg commented Jun 19, 2026

Copy link
Copy Markdown
MemberAuthor

@arturobernalg This change can still make it into 5.7 if you are willing to invest time into it.

@ok2c please do another pass

ok2c
ok2c reviewed Jul 4, 2026
View reviewed changes
Comment threadhttpclient5/src/main/java/org/apache/hc/client5/http/ConnectAlpnProvider.java Outdated
@arturobernalg
arturobernalg requested a review from ok2cJuly 11, 2026 17:57
@arturobernalg
arturobernalgforce-pushed the rfc7639 branch 2 times, most recently from 05a370f to 0af7b0fCompareJuly 11, 2026 18:07
ok2c
ok2c reviewed Jul 17, 2026
View reviewed changes

@ok2cok2c left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arturobernalg Much, much better! However, we need to figure out a better of way of passing the actual TLS policy to the interceptors. I would try to solve it by adding HttpVersionPolicy as an attribute to HttpClientContext

@arturobernalg
Add RFC 7639 ALPN header codec; emit ALPN on CONNECT tunnels
d16d456
Encode protocol IDs with core's PercentCodec.HTTP_TOKEN (canonical RFC 7230 tchar form, uppercase hex) and decode strictly, rejecting malformed percent-encoding with ProtocolException.
The advertised protocol set is derived from the target's HttpVersionPolicy. The connection manager resolves the effective TlsConfig and publishes the policy on HttpClientContext before the connection is established; ConnectExec and AsyncConnectExec read it back and, on secure CONNECT tunnels, advertise the same protocols the tunnel's TLS layer will offer, so the header cannot diverge from the protocol negotiated inside the tunnel. Interceptors fall back to NEGOTIATE when no policy is present on the context.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ok2cok2cAwaiting requested review from ok2c

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arturobernalg@ok2c