Skip to content

Rfc6724 resolver ordering semantics - #778

Open
arturobernalg wants to merge 3 commits into
apache:masterfrom
arturobernalg:Rfc6724A
Open

Rfc6724 resolver ordering semantics#778
arturobernalg wants to merge 3 commits into
apache:masterfrom
arturobernalg:Rfc6724A

Conversation

@arturobernalg

@arturobernalgarturobernalg commented Jan 9, 2026

Copy link
Copy Markdown
Member

Introduce Rfc6724AddressSelectingDnsResolver and unit tests.
Define INTERLEAVE as “no bias” (preserve RFC6724 order); keep ONLY/PREFER behavior unchanged.

@arturobernalgarturobernalg mentioned this pull request Jan 9, 2026
Open
rschmitt
rschmitt requested changes Jan 12, 2026
View reviewed changes

@rschmittrschmitt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main thing here is that I'd like to see a proper implementation of INTERLEAVE, more unit test coverage, and an example program we can use for manual testing.

Comment thread...client5/src/test/java/org/apache/hc/client5/http/Rfc6724AddressSelectingDnsResolverTest.java Outdated
Comment threadhttpclient5/src/main/java/org/apache/hc/client5/http/Rfc6724AddressSelectingDnsResolver.java Outdated
Comment threadhttpclient5/src/main/java/org/apache/hc/client5/http/AddressSelectingDnsResolver.java
Comment threadhttpclient5/src/main/java/org/apache/hc/client5/http/Rfc6724AddressSelectingDnsResolver.java Outdated
Comment threadhttpclient5/src/main/java/org/apache/hc/client5/http/AddressSelectingDnsResolver.java
Comment threadhttpclient5/src/main/java/org/apache/hc/client5/http/AddressSelectingDnsResolver.java
Comment threadhttpclient5/src/main/java/org/apache/hc/client5/http/config/ProtocolFamilyPreference.java
Comment threadhttpclient5/src/main/java/org/apache/hc/client5/http/Rfc6724AddressSelectingDnsResolver.java Outdated
InetAddress src = null;
try (final DatagramSocket s = new DatagramSocket()) {
s.connect(dest); // does not send packets; OS picks source addr/if
src = s.getLocalAddress();

@rschmittrschmittJan 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably want to inject a thing here that you can mock for unit testing purposes, e.g. a Function<InetSocketAddress, InetAddress> (or an equivalent that throws IOException).

Comment thread...client5/src/test/java/org/apache/hc/client5/http/Rfc6724AddressSelectingDnsResolverTest.java Outdated
Comment threadhttpclient5/src/main/java/org/apache/hc/client5/http/Rfc6724AddressSelectingDnsResolver.java Outdated
@arturobernalg

arturobernalg commented Jan 13, 2026

Copy link
Copy Markdown
MemberAuthor

@rschmitt Please do another pass. I think i solve all your remarks

rschmitt
rschmitt reviewed Jan 14, 2026
View reviewed changes
Comment threadhttpclient5-testing/src/test/java/org/apache/hc/client5/testing/ManualRfc6724ResolverIT.java Outdated
Comment threadhttpclient5/src/main/java/org/apache/hc/client5/http/Rfc6724AddressSelectingDnsResolver.java Outdated
Comment threadhttpclient5/src/main/java/org/apache/hc/client5/http/AddressSelectingDnsResolver.java
Comment threadhttpclient5/src/main/java/org/apache/hc/client5/http/Rfc6724AddressSelectingDnsResolver.java Outdated
Comment threadhttpclient5/src/main/java/org/apache/hc/client5/http/AddressSelectingDnsResolver.java
Comment threadhttpclient5/src/main/java/org/apache/hc/client5/http/Rfc6724AddressSelectingDnsResolver.java Outdated
Comment threadhttpclient5/src/test/java/org/apache/hc/client5/http/examples/Rfc6724ResolverExample.java Outdated
Comment thread...client5/src/test/java/org/apache/hc/client5/http/Rfc6724AddressSelectingDnsResolverTest.java Outdated
Comment thread...client5/src/test/java/org/apache/hc/client5/http/Rfc6724AddressSelectingDnsResolverTest.java Outdated
Comment threadhttpclient5-testing/src/test/java/org/apache/hc/client5/testing/ManualRfc6724ResolverIT.java Outdated
@rschmitt

rschmitt commented Jan 14, 2026

Copy link
Copy Markdown
Contributor

There are some things from my first review that still haven't been addressed. I suggest going through the comments one by one and hitting "Resolve conversation" as you address each one, so you can track what is and isn't done.

@arturobernalg

arturobernalg commented Jan 15, 2026

Copy link
Copy Markdown
MemberAuthor

There are some things from my first review that still haven't been addressed. I suggest going through the comments one by one and hitting "Resolve conversation" as you address each one, so you can track what is and isn't done.

Hi @rschmitt I believe I’ve addressed all your remarks in the latest update.

@arturobernalg
Add RFC6724-based DNS resolver with configurable family preference.
08a615b
Define INTERLEAVE as no-bias and align tests and debug output.
@arturobernalg
Implement true INTERLEAVE ordering.
0f91122
Add manual gated IT to dump DEFAULT vs INTERLEAVE results.
Expand unit coverage for scope mapping and core RFC comparison rules.
@arturobernalg

arturobernalg commented Mar 25, 2026

Copy link
Copy Markdown
MemberAuthor

Hi @rschmitt ,

All your review comments are addressed. Additional fixes since last time:

  • IPv4 scope mapping fixed per RFC 6724 (127/8, 169.254/16 → link-local; everything else → global)
  • ::1 → link-local (interface-local is multicast-only)
  • Rule 9 now applies to IPv4 pairs too
  • No early return before filtering (single-address edge case)
  • resolve(host, port) throws instead of returning unresolved (prevents bypassing family filtering)
  • Rule 9 documented as heuristic (JDK limitation)

@arturobernalg
Apply RFC 6724 destination ordering and family preferences to DNS res…
d8d2dab
…ults.
Tighten resolver semantics and filtering for HTTP/TCP connect targets.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rschmittrschmittAwaiting requested review from rschmitt

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arturobernalg@rschmitt