Uh oh!
There was an error while loading. Please reload this page.
Multi/Cloud FS Support for Copy-On-Write tables - #293
Merged
Conversation
vinothchandar
commented
Jan 3, 2018
MemberAuthor
Tests pass locally.. debugging why it fails on travis. |
vinothchandarforce-pushed
the
s3-support
branch
6 times, most recently
from
January 4, 2018 03:56
7245522 to
282a436Compareprazanna
approved these changes
Jan 18, 2018
prazanna
left a comment
Contributor
There was a problem hiding this comment.
This looks good. Glad we were able to get this working. One caveat to be wary about - If the client and the hadoop cluster distribution is different the Configuration serializable may not work right.
- Reviving PR 191, to make FileSystem creation off actual path - Streamline all filesystem access to HoodieTableMetaClient - Hadoop Conf from Spark Context serialized & passed to executor code too - Pick up env vars prefixed with HOODIE_ENV_ into Configuration object - Cleanup usage of FSUtils.getFS, piggybacking off HoodieTableMetaClient.getFS - Adding s3a to supported schemes & support escaping "." in env vars - Tests use HoodieTestUtils.getDefaultHadoopConf
- When append() is not supported, rollover to new file always (instead of failing) - Provide way to configure archive log folder (avoids small files inside .hoodie) - Datasets written via Spark datasource archive to .hoodie/archived - HoodieClientExample will now retain only 2,3 commits to exercise archival path during dev cycles - Few tweaks to code structure around CommitArchiveLog
vinothchandarforce-pushed
the
s3-support
branch
from
January 18, 2018 07:22
282a436 to
2d3d34eCompare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses few issues for s3 support #110#120 , subsumes #191 . Its touches a lot of files, but most of it is cleaning up some debt, key changes called out in commit summaries.
Tested on some jobs reading from s3 and writing to HDFS, HDFS to HDFS & so on.. CLI works with S3 datasets via env var setting as well..
cc @n3nash@ovj@jianxu for double checking that changes to archive log don't impact production at Uber.
cc @zqureshi@alunarbeach who may be interested in this..