Uh oh!
There was an error while loading. Please reload this page.
[HUDI-4632] Map Flink artifact ids correctly as per scala dependence - #6437
Closed
codope wants to merge 1 commit into
Closed
[HUDI-4632] Map Flink artifact ids correctly as per scala dependence#6437codope wants to merge 1 commit into
codope wants to merge 1 commit into
Conversation
pratyakshsharma
commented
Aug 18, 2022
Contributor
Verified with |
hudi-bot
commented
Aug 18, 2022
Collaborator
| <flink.version>${flink1.15.version}</flink.version> | ||
| <flink.runtime.artifactId>flink-runtime</flink.runtime.artifactId> | ||
| <flink.table.runtime.artifactId>flink-table-runtime</flink.table.runtime.artifactId> | ||
| <flink.table.planner.artifactId>flink-table-planner_2.12</flink.table.planner.artifactId> |
Contributor
There was a problem hiding this comment.
The default active profile is flink1.14, and it already specifies the jar artifactIds, so what's the problem here
Contributor
There was a problem hiding this comment.
Fix the default flink version line 131 ~ line 133:
<flink.version>${flink1.14.version}</flink.version>
<hudi.flink.module>hudi-flink1.14.x</hudi.flink.module>
<flink.bundle.version>1.14</flink.bundle.version>should also work ?
MemberAuthor
There was a problem hiding this comment.
If not changing the artofact ids, then i think changing the default flink profile from flink1.13 to flink1.15 should work. I guess that's what #6445 is doing.
danny0405
commented
Aug 19, 2022
Contributor
Thanks, i have fired a fix in https://github.com/apache/hudi/pull/6445/files |
codope
commented
Aug 29, 2022
MemberAuthor
Closing it in favor of #6445 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Fixes the issue reported in #6422
Since the default flink profile is still scala version dependent, so the default artifact ids should be named correctly.
Tested all 3 flink profiles.
Impact
Describe any public API or user-facing feature change or any performance impact.
Risk level: none | low | medium | high
Choose one. If medium or high, explain what verification was done to mitigate the risks.
Contributor's checklist