Uh oh!
There was an error while loading. Please reload this page.
chore: bump C++ standard to 23 - #139
Conversation
zhjwpku
commented
Jul 5, 2025
Waiting apache/arrow#46998 to be resolved, but should be fine for review. |
wgtmac
commented
Jul 8, 2025
This is no longer a draft, right? |
zhjwpku
commented
Jul 8, 2025
Yeah, I just make it ready for review. |
The commit includes apache/arrow#46912, which are resolve our frequent CI failures.
I just changed to a more recent arrow commit which contains the Apache Thrift update[1], which should fix our frequent CI failure. |
mapleFU
commented
Jul 8, 2025
So should Besides, C++23 has resize_and_overwrite, allowing zero-cost buffer initialization |
zhjwpku
commented
Jul 8, 2025
Personally I think Result/Status are well-structured wrappers, but I'm glad to hear others' opinions.
Ah, I wasn't aware of this feature, could you suggest where it might be applied? I think we can adopt more C++23 features in future PRs, assuming compiler support. I tried using |
wgtmac
commented
Jul 8, 2025
I think we need to update it to use Apache Arrow 21.0.0 once it is released. It is only a temporary state to pin to an unreleased version. |
zhjwpku
commented
Jul 9, 2025
Sure, will keep an eye on it. |
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you for working on this, let's move!
No description provided.