Uh oh!
There was an error while loading. Please reload this page.
Remove deprecated datetime functions - #1134
Conversation
| snapshots.append({ | ||
| "committed_at": datetime.utcfromtimestamp(snapshot.timestamp_ms / 1000.0), | ||
| "committed_at": datetime.fromtimestamp(snapshot.timestamp_ms / 1000.0, tz=timezone.utc), |
There was a problem hiding this comment.
| "ignore:unclosed <socket.socket", | ||
| # Remove this in a future release of PySpark. | ||
| "ignore:distutils Version classes are deprecated. Use packaging.version instead.", | ||
| "ignore:datetime.datetime.utcnow\\(\\) is deprecated and scheduled for removal in a future version.", |
There was a problem hiding this comment.
huh, not sure where this went, theres no references in the codebase
https://github.com/search?q=repo%3Aapache%2Ficeberg-python%20utcnow&type=code
There was a problem hiding this comment.
it might be used in one of the dependency packages, but we don't need to filter the warning in that case
Fokko
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up @hussein-awala Could you resolve the conflicts? Thanks!
hussein-awala
commented
Nov 7, 2024
I did and looks like the usage of the deprecated method was removed by another PR, this one now just removes the useless warning. |
kevinjqliu
commented
Nov 8, 2024
https://github.com/search?q=repo%3Aapache%2Ficeberg-python%20utcfromtimestamp&type=code |
Fokko
commented
Nov 19, 2024
@kevinjqliu Let's move this forward for now. Thanks @hussein-awala for fixing this 👍 |
* Remove deprecated datetime functions * remove all usage of deprecated methods * readd utcnow filter because of boto3
* Remove deprecated datetime functions * remove all usage of deprecated methods * readd utcnow filter because of boto3
closes: #1133