Skip to content

Ignore tables without table_type parameters while loading all iceberg table from Glue and Hive catalog - #1332

Merged
Fokko merged 2 commits into
apache:mainfrom
gitzwz:1331
Nov 19, 2024
Merged

Ignore tables without table_type parameters while loading all iceberg table from Glue and Hive catalog#1332
Fokko merged 2 commits into
apache:mainfrom
gitzwz:1331

Conversation

@gitzwz

@gitzwzgitzwz commented Nov 18, 2024•
edited by Fokko
Loading

Copy link
Copy Markdown
Contributor

Fixes#1331
Fixes#1150

@gitzwz

gitzwz commented Nov 18, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

same problem with #1258, I also added some tests for this.

HonahX
HonahX reviewed Nov 19, 2024
View reviewed changes

@HonahXHonahX left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @gitzwz Thanks for fixing this and adding tests for both catalogs.

Just have one minor non-blocking request : )

Comment threadpyiceberg/catalog/hive.py Outdated
Fokko
Fokko approved these changes Nov 19, 2024
View reviewed changes

@FokkoFokko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @gitzwz, and thanks for the review @HonahX 🙌

@Fokko
Fokko merged commit a66ddc0 into apache:mainNov 19, 2024
@gitzwz
gitzwz deleted the 1331 branch November 20, 2024 03:50
@kevinjqliukevinjqliu mentioned this pull request Nov 25, 2024
Merged
@kevinjqliukevinjqliu changed the title Ignore tables without table_type parameters while loading all iceberg table from Glue and Hive catalog (#1331)Ignore tables without table_type parameters while loading all iceberg table from Glue and Hive catalogNov 25, 2024
@kevinjqliukevinjqliu added this to the PyIceberg 0.8.1 release milestone Nov 26, 2024
@kevinjqliukevinjqliu mentioned this pull request Nov 27, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FokkoFokkoFokko approved these changes
@HonahXHonahXHonahX approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

PyIceberg 0.8.1 release

4 participants

@gitzwz@Fokko@HonahX@kevinjqliu