Skip to content

Set default for SortField's transform - #1347

Merged
Fokko merged 2 commits into
apache:mainfrom
kevinjqliu:kevinjqliu/sort-init-value
Nov 20, 2024
Merged

Set default for SortField's transform#1347
Fokko merged 2 commits into
apache:mainfrom
kevinjqliu:kevinjqliu/sort-init-value

Conversation

@kevinjqliu

@kevinjqliukevinjqliu commented Nov 20, 2024

Copy link
Copy Markdown
Contributor

Fixes#1337 (nice)

Added a test to validate

@FokkoFokko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @kevinjqliu, thanks for adding the test 👍

@Fokko
Fokko merged commit 150fa0c into apache:mainNov 20, 2024
@kevinjqliu
kevinjqliu deleted the kevinjqliu/sort-init-value branch November 20, 2024 17:16
This was referenced Nov 25, 2024
sungwy pushed a commit to sungwy/iceberg-python that referenced this pull request Dec 7, 2024
sungwy pushed a commit to sungwy/iceberg-python that referenced this pull request Dec 7, 2024
sungwy pushed a commit to sungwy/iceberg-python that referenced this pull request Dec 24, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SortField requires you to specify a transform?

2 participants

@kevinjqliu@Fokko