Uh oh!
There was an error while loading. Please reload this page.
TEST: adopt new rest catalog image and enable tableExists tests - #1389
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Fokko
commented
Dec 4, 2024
The image is published, including the fix around the |
Fokko
commented
Dec 4, 2024
Hmm, still an issue with the |
sungwy
commented
Dec 4, 2024
:) @Fokko I'm on my way to the office, but will take a look at this in a few minutes |
sungwy
commented
Dec 4, 2024
@Fokko - it looks like the issue is because the rest-fixture is returning a 200 response. I've put in edits to allow PyIceberg to infer a 200 response as being successful. The proposed solution deviates from the REST Catalog Spec, but this is already the behavior of PyIceberg when handles the success codes of the other endpoints that are also meant to return 204 response: iceberg-python/pyiceberg/catalog/rest.py Lines 422 to 448 in df804c4 |
Fokko
commented
Dec 4, 2024
| if response.status_code == 404: | ||
| return False | ||
| elif response.status_code == 204: | ||
| elif response.status_code in (200, 204): |
There was a problem hiding this comment.
should we upstream this to the spec?
sungwy
commented
Dec 7, 2024
Thanks for the reviews @Fokko and @kevinjqliu ! |
…he#1389) * test new rest catalog image * Point to `iceberg-rest-fixture` * allow 200 response in table_exists * be graceful in handling 200 response in table_exists --------- Co-authored-by: Fokko Driesprong <fokko@apache.org>
…he#1389) * test new rest catalog image * Point to `iceberg-rest-fixture` * allow 200 response in table_exists * be graceful in handling 200 response in table_exists --------- Co-authored-by: Fokko Driesprong <fokko@apache.org>
…he#1389) * test new rest catalog image * Point to `iceberg-rest-fixture` * allow 200 response in table_exists * be graceful in handling 200 response in table_exists --------- Co-authored-by: Fokko Driesprong <fokko@apache.org>
NOTE: the test is failing because tableExists endpoint isn't exposed on the adapter. Related fix: apache/iceberg#11678