Uh oh!
There was an error while loading. Please reload this page.
[View Support] Add ViewMetadata read support and create_view to REST Catalog - #2154
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
jayceslesar
commented
Jun 28, 2025
Is it worth setting integration tests in rest integration tests? |
rambleraptor
commented
Jun 29, 2025
I'm a little unclear what Catalog the REST integration tests run against, so I can't say if there's been enough implemented to actually have a valid REST Catalog test. The integration tests are missing most of the methods that have been implemented, so my reaction is that we're still missing pieces for an integration test. |
rambleraptor
commented
Jul 1, 2025
@Fokko@kevinjqliu mind taking a look when you can? thanks! |
Uh oh!
There was an error while loading. Please reload this page.
sungwy
left a comment
There was a problem hiding this comment.
Thanks for taking this up @rambleraptor
I've taken a stab at reviewing the PR. I think adding an integration test is a must-have for introducing a new API. I think a great way to verify that the created view works as expected is to add a view as a spark dialect sql view and read the view table through a spark session, similar to how we validate that PyIceberg writes are reflected correctly even when the table is read through a Spark session accessing the same REST Catalog (example). WDYT?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
rambleraptor
commented
Jul 2, 2025
@sungwy@jayceslesar please take a look when you can! |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
rambleraptor
commented
Jul 3, 2025
addressed the comments, thanks for the review! |
sungwy
commented
Jul 4, 2025
Hi @rambleraptor the CI is failing due to a lint error. Could you run |
rambleraptor
commented
Jul 4, 2025
@sungwy whoops, thanks! all fixed. |
rambleraptor
commented
Jul 10, 2025
@sungwy@jayceslesar@Fokko can I get a review on this when you can? Thanks! |
create_view to REST Catalogcreate_view to REST Catalogcreate_view to REST Catalogcreate_view to REST Catalogsjdurfey
commented
Feb 11, 2026
is this issue dead? |
1c7ff03 to
f1f0a73Comparerambleraptor
commented
Feb 11, 2026
@sjdurfey I just updated the PR to handle the merge conflicts. I'm definitely interested in getting more View support in and I think this PR is a good place to begin! @kevinjqliu@Fokko fyi, ptal! |
Fokko
left a comment
There was a problem hiding this comment.
Left some small comments, but this looks good to me 👍
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Sung Yun <107272191+sungwy@users.noreply.github.com>
Co-authored-by: Sung Yun <107272191+sungwy@users.noreply.github.com>
Co-authored-by: Sung Yun <107272191+sungwy@users.noreply.github.com>
Co-authored-by: Sung Yun <107272191+sungwy@users.noreply.github.com>
Co-authored-by: Sung Yun <107272191+sungwy@users.noreply.github.com>
3b6c67d to
1065254Comparerambleraptor
commented
Feb 23, 2026
@Fokko changes made! On vacation the last week, thanks for being patient! |
Uh oh!
There was an error while loading. Please reload this page.
Fokko
commented
Mar 7, 2026
Hope you had a great vacation @rambleraptor, and thanks for working on this! |
…he#2154) <!-- Thanks for opening a pull request! --> <!-- In the case this PR will resolve an issue, please replace ${GITHUB_ISSUE_ID} below with the actual Github issue id. --> <!-- Closes #${GITHUB_ISSUE_ID} --> Part of apache#818 This adds `create_view` to the REST Catalog. As part of this, it also defines the View and ViewMetadata class. # Rationale for this change PyIceberg's REST Catalog doesn't support `create_view`. Furthermore, PyIceberg doesn't support views at all. This is the first part in getting views supported. # Are these changes tested? Unit tests included # Are there any user-facing changes? Added Iceberg REST Catalog support for `create_view` <!-- In the case of user-facing changes, please add the changelog label. --> --------- Co-authored-by: Sung Yun <107272191+sungwy@users.noreply.github.com> Co-authored-by: Fokko Driesprong <fokko@apache.org>
Part of #818
This adds
create_viewto the REST Catalog. As part of this, it also defines the View and ViewMetadata class.Rationale for this change
PyIceberg's REST Catalog doesn't support
create_view. Furthermore, PyIceberg doesn't support views at all. This is the first part in getting views supported.Are these changes tested?
Unit tests included
Are there any user-facing changes?
Added Iceberg REST Catalog support for
create_view