Replace pre-commit by prek

[luizvbo]

Rationale for this change

It replaces pre-commit with prek, which is almost 10x faster. prek is a port of pre-commit to rust.

Are these changes tested?

Yes. make lint is running locally

Are there any user-facing changes?

Only for developers, given that it affects make lint,

NOTE: I had to update the poetry.lock file with poetry lock, resulting in multiple changes. Maybe it's better to run again in your machine (I don't know if it's run automatically in the CI pipeline).

[luizvbo]

Closes #2533

[luizvbo]

Hello! Could you review this PR for me? Thanks in advance

[Fokko]

Thanks for working on this! 🥳

NOTE: I had to update the poetry.lock file with poetry lock, resulting in multiple changes. Maybe it's better to run again in your machine (I don't know if it's run automatically in the CI pipeline).

This is not really an issue; however, running it from different machines (and also Dependabot does this) will result in more conflicts.

[luizvbo]

Strange... The tests are working in my machine (python 3.12), but failing in the CI (python 3.11). It's strange, because I didn't touch src. I think it might be caused by updating the packages in the poetry.lock file

[luizvbo]

@Fokko, I think the issue is fixed now (tests are passing locally with py 3.11). I had to set an upper limit for the datafusion package, given that tests fail in py3.11 after version 48.

[Fokko]

Nice, this looks great @luizvbo! I'm positive, let's see what @kevinjqliu thinks!

[kevinjqliu]

LGTM

An improvement in runtime!

prek: make lint 8.10s user 1.18s system 255% cpu 3.638 total
poetry: make lint 11.65s user 1.76s system 171% cpu 7.815 total

[kevinjqliu]

i tested locally that this passes without the extra <49

poetry lock
make install
poetry run pytest tests/table/test_datafusion.py 

[kevinjqliu]

its fine to leave as is. due to limitations we actually cannot use datafusion 49, so this makes sense

[kevinjqliu]

thank you @luizvbo and thanks @Fokko for the review