Skip to content

support python 3.12 - #254

Closed
MehulBatra wants to merge 4 commits into
apache:mainfrom
MehulBatra:support_python312
Closed

support python 3.12#254
MehulBatra wants to merge 4 commits into
apache:mainfrom
MehulBatra:support_python312

Conversation

@MehulBatra

@MehulBatraMehulBatra commented Jan 7, 2024

Copy link
Copy Markdown
Contributor
  1. ray seems to be a blocker as they do not support python3.12 as of now
image

[Open Ticket for Ray 3.12 Support] (ray-project/ray#40211)

  1. duckdb doesn't support 3.12 and still has a build mechanism via distutils
  • Tentative release for Duckdb supporting 3.12 is 29Jan, Version 0.10
image
  1. Dual version dependency for numpy to support 3.12,

  2. Upgraded greenlet to 3.0.3 to support Python 3.12, with dual dependency

  3. python 3.12 no longer supports distutils PEP632, we need to upgrade packages that get installed with support of PEP517 builds

@MehulBatraMehulBatra changed the title bump greenlet, numpy, remove support for 3.8support python 3.12Jan 8, 2024
Comment threadpyproject.toml Outdated
Comment threadpyproject.toml Outdated
@cclauss

cclauss commented Jan 13, 2024

Copy link
Copy Markdown

Similar to

@Fokko Can you please approve the workflow run so we can see the results of the tests?

Comment threadpyproject.toml Outdated
@Fokko

Copy link
Copy Markdown
Contributor

@MehulBatra can you rebase?

@MehulBatra

Copy link
Copy Markdown
ContributorAuthor

@MehulBatra can you rebase?

rebased it but It will still fail for 3.12 due to ray support, I am keeping a close eye on it.

@MehulBatraMehulBatra mentioned this pull request May 18, 2024
@MehulBatra

Copy link
Copy Markdown
ContributorAuthor

Tentative ray support for 3.12 -> ray-project/ray#40211 (comment)

@MehulBatra

Copy link
Copy Markdown
ContributorAuthor

PR being worked on for Ray 3.12: ray-project/ray#45477

@pdpark

Copy link
Copy Markdown

FYI: Ray issue 45477 was recently completed.

@MehulBatra

Copy link
Copy Markdown
ContributorAuthor

FYI: Ray issue 45477 was recently completed.

Thank you so much for the update! @pdpark
Soon there will be a release too I believe (will keep an eye on the same), and then we can hit the road!

@MehulBatra

Copy link
Copy Markdown
ContributorAuthor

@Fokko could you please run the CI/CD

@Fokko

Fokko commented Jul 1, 2024

Copy link
Copy Markdown
Contributor

@MehulBatra Certainly! How do you feel like splitting the strtobool into a separate PR? I think it would be good to already have that in to enable Python 3.12 support with engines other than Ray.

@MehulBatra

Copy link
Copy Markdown
ContributorAuthor

@MehulBatra Certainly! How do you feel like splitting the strtobool into a separate PR? I think it would be good to already have that in to enable Python 3.12 support with engines other than Ray.

That makes sense, I will raise separate PR for the same.

@MehulBatra

Copy link
Copy Markdown
ContributorAuthor

@Fokko I have separated the strtobool in a separate PR, please have a look
#880

@cclauss

Copy link
Copy Markdown

pytest is kicking out a bunch of warnings that someone should be investigating.

Python 3.13 is in beta 3 so should testing be started on it as well? https://www.python.org/download/pre-releases

@Jiafi

Copy link
Copy Markdown

looks like the next release of ray should hopefully have 3.12 support

@cclauss

Copy link
Copy Markdown

Cool! Python 3.13 is scheduled to be released on October 1st.

@kevinjqliu

Copy link
Copy Markdown
Contributor

hey @MehulBatra, can i close this in favor of #1068?

@MehulBatra

Copy link
Copy Markdown
ContributorAuthor

hey @MehulBatra, can i close this in favor of #1068?

yes please go ahead @kevinjqliu

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@MehulBatra@cclauss@Fokko@pdpark@Jiafi@kevinjqliu