Uh oh!
There was an error while loading. Please reload this page.
Make UnaryPredicate JSON Serializable and Add Unit Tests - #2598
Merged
Fokko merged 6 commits intoOct 22, 2025
Conversation
Aniketsyforce-pushed
the
make-unarypredicate-json-serializable
branch
from
October 18, 2025 08:28
ad99ec8 to
9d333eeCompareAniketsy
commented
Oct 18, 2025
ContributorAuthor
@Fokko please review these changes , when you get a chance. |
Fokko
reviewed
Oct 19, 2025
Uh oh!
There was an error while loading. Please reload this page.
Fokko
reviewed
Oct 19, 2025
Uh oh!
There was an error while loading. Please reload this page.
Aniketsyforce-pushed
the
make-unarypredicate-json-serializable
branch
from
October 20, 2025 08:50
4096627 to
9c9b3c4CompareFokko
reviewed
Oct 20, 2025
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Fokko Driesprong <fokko@apache.org>
Aniketsy
commented
Oct 21, 2025
ContributorAuthor
@Fokko While testing locally, I’m getting 15 test failures, but in the CI check, there’s only 1 test failing. Could you please help me understand what might be causing this difference? |
Fokko
commented
Oct 21, 2025
Contributor
@Aniketsy Sure thing, I'm happy to. Could you share the output of the console? |
Fokko
reviewed
Oct 21, 2025
Uh oh!
There was an error while loading. Please reload this page.
Aniketsy
commented
Oct 21, 2025
ContributorAuthor
sure, |
Co-authored-by: Fokko Driesprong <fokko@apache.org>
Uh oh!
There was an error while loading. Please reload this page.
Aniketsy
commented
Oct 22, 2025
ContributorAuthor
@Fokko Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2522
This PR makes the
UnaryPredicateclass and its subclasses (IsNull,NotNull,IsNaN,NotNaN) JSON serializable using PydanticPlease let me know if my approach or fix needs any improvements . I’m open to feedback and happy to make changes based on suggestions.
Thankyou !