Uh oh!
There was an error while loading. Please reload this page.
feat: Add support for rolling back to snapshot - #2878
Conversation
| """ | ||
| self._commit_if_ref_updates_exist() | ||
| if (snapshot_id is None) == (ref_name is None): |
There was a problem hiding this comment.
this is a silly nit but why do this? This looks almost java-esque and could be
| if(snapshot_idisNone) == (ref_nameisNone): | |
| ifsnapshot_idisNoneandref_nameisNone: |
There was a problem hiding this comment.
Yeah lol I just cleaned up the original in a pythonish way to say one must be set. However, seems like this is confusing
There was a problem hiding this comment.
you could probably do some fanciness with any and all but not gonna harp on it
Uh oh!
There was an error while loading. Please reload this page.
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM!
I think it would be good to include some of the mocked test cases in tests/integration/test_snapshot_operations.py on actual tables. Mock tests can only do so much 😞
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM Thanks for adding the tests!
Uh oh!
There was an error while loading. Please reload this page.
kevinjqliu
commented
Jan 15, 2026
Thanks for the PR @geruh and thanks for the review @jayceslesar |
# Rationale for this change This PR adds the ability to rollback a table to a ancestoral snapshot given a timestamp. Some of this work was also done in #758, and is a progress pr to be merged after #2871 & #2878. This is standalone from the other changes but it makes use of the helpers in the other prs. Additionally, adding some more tests. ## Are these changes tested? Yes ## Are there any user-facing changes? New API for meta --------- Co-authored-by: Chinmay Bhat <12948588+chinmay-bhat@users.noreply.github.com>
Rationale for this change
This PR adds the ability to rollback a table to a ancestoral snapshot. Some of this work was also done in #758, and is a progress pr to be merged after #2871.
Additionally, adding some more tests.
Are these changes tested?
Yes
Are there any user-facing changes?
New API