Skip to content

Add support for registering views - #3288

Merged
Fokko merged 4 commits into
apache:mainfrom
ebyhr:ebi/register_view
May 11, 2026
Merged

Add support for registering views#3288
Fokko merged 4 commits into
apache:mainfrom
ebyhr:ebi/register_view

Conversation

@ebyhr

@ebyhrebyhr commented Apr 26, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Rationale for this change

Are these changes tested?

tests/catalog/test_rest.py contains new tests.

Are there any user-facing changes?

This PR adds a new register_view method to catalog.

@ndrluisndrluis mentioned this pull request Apr 26, 2026
Open
8 tasks
gabeiglio
gabeiglio reviewed Apr 26, 2026
View reviewed changes
Comment threadpyiceberg/catalog/rest/__init__.py
geruh
geruh reviewed Apr 27, 2026
View reviewed changes
Comment threadpyiceberg/catalog/rest/__init__.py
Comment threadpyiceberg/catalog/rest/__init__.py Outdated
Comment threadtests/catalog/test_rest.py Outdated
@rambleraptor

rambleraptor commented Apr 28, 2026

Copy link
Copy Markdown
Collaborator

Does the REST fixture support register_view? An integration test on this would be great.

@ebyhr

ebyhr commented Apr 28, 2026

Copy link
Copy Markdown
MemberAuthor

@rambleraptor No, the current test target 1.10.x doesn't support the endpoint.

@ebyhr
ebyhrforce-pushed the ebi/register_view branch 2 times, most recently from cd7d26a to f389b33CompareApril 28, 2026 02:57
@ebyhr
ebyhrforce-pushed the ebi/register_view branch from f389b33 to af7a73cCompareApril 28, 2026 03:25
@ebyhr

ebyhr commented May 5, 2026

Copy link
Copy Markdown
MemberAuthor

@geruh Could you take another look when you have time?

Fokko
Fokko approved these changes May 6, 2026
View reviewed changes
Comment threadpyiceberg/catalog/__init__.py Outdated
geruh
geruh reviewed May 7, 2026
View reviewed changes
Comment threadtests/catalog/test_rest.py Outdated
status_code=200,
request_headers=TEST_HEADERS,
)
rest_mock.post(

@geruhgeruhMay 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non blocking nit: we don't need this code block since we hit on self.table_exists() call.

@Fokko
Fokko merged commit e598827 into apache:mainMay 11, 2026
17 checks passed
@Fokko

Fokko commented May 11, 2026

Copy link
Copy Markdown
Contributor

Thanks @ebyhr for working on this, and thanks for the review @ndrluis, @gabeiglio and @geruh 🚀

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geruhgeruhgeruh left review comments
@FokkoFokkoFokko approved these changes
+2 more reviewers
@gabeigliogabeigliogabeiglio left review comments
@ndrluisndrluisndrluis approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ebyhr@rambleraptor@Fokko@ndrluis@geruh@gabeiglio