Uh oh!
There was an error while loading. Please reload this page.
Add support for 'overwrite' option in register_table - #3290
Conversation
gabeiglio
commented
Apr 26, 2026
Looks good to me, one small nit would be to add some tests in integration tests here if the iceberg rest image supports the overwriting flag |
ebyhr
commented
Apr 26, 2026
The current test target (1.10.0) supports the option in OpenAPI yml, but the catalog doesn't support it. We can add an integration test once 1.11.0 (apache/iceberg#15525) is released. |
djouallah
commented
May 3, 2026
any chance for this to get merged, currently, i am doing tuncate and add files with other tool, and it is a pain as it is not atomic |
| Args: | ||
| identifier (Union[str, Identifier]): Table identifier for the table | ||
| metadata_location (str): The location to the metadata | ||
| overwrite (bool): Whether to overwrite the existing table, default False |
There was a problem hiding this comment.
should we add NotImplementedError here too?
There was a problem hiding this comment.
This method in dynamodb and noop always raises NotImplementedError. Do we still need a separate logc for the overwrite argument?
There was a problem hiding this comment.
I see NotImplementedError in other implementations but not for dynamodb/noop
is that intended?
There was a problem hiding this comment.
That is intentional because those two catalogs don't support registering tables and always raise NotImplementedError.
There was a problem hiding this comment.
ahh thanks for the explanation!
| Args: | ||
| identifier (Union[str, Identifier]): Table identifier for the table | ||
| metadata_location (str): The location to the metadata | ||
| overwrite (bool): Whether to overwrite the existing table, default False |
There was a problem hiding this comment.
nit: raise NotImplementedError here too?
Uh oh!
There was an error while loading. Please reload this page.
Fokko
commented
May 4, 2026
Right now we're locked at an older version of the Image: #3240. Once there is a new Java release, we can definitly add this test.
@djouallah Since everybody approved, I went ahead and merged this 👍 Thanks @ebyhr for working on this, and thanks @ndrluis and @kevinjqliu for the review 🚀 |
Rationale for this change
Are these changes tested?
Are there any user-facing changes?
This PR adds
overwriteparameter tocatalog.register_tablemethod.