Uh oh!
There was an error while loading. Please reload this page.
infra: add python 3.14 support - #3299
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Could you also test the Manual trigger with these parameters: and include the link in the PR This will help test the changes in |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
kevinjqliu
commented
May 1, 2026
i think we can use this And remove WDYT? |
afeldman1
commented
May 2, 2026
@kevinjqliu That looks the same as what I had originally attempted in this commit, which failed on integration test due to not picking up the env variable, set at that point in the flow. |
Fokko
commented
May 2, 2026
Thanks for working on this @afeldman1. I think in general this looks good, but I think it would be good to document |
hm do you remember what the error was? this worked for me when i tested it locally EDIT: nevermind, i didnt remove the env var declaration in Makefile |
ok i tried this solution, we can override it using pytest hook.
tested that it works with |
afeldman1
commented
May 2, 2026
@Fokko Where were you thinking the documentation should go? |
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM! Thanks for adding this.
could you retrigger https://github.com/afeldman1/iceberg-python/actions/workflows/python-release.yml for a final check
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
kevinjqliu
commented
May 3, 2026
Thanks for the PR @afeldman1 |
afeldman1
commented
May 3, 2026
@kevinjqliu Thanks for the support! |
Rationale for this change
Adds prebuilt support for python 3.14
Free-threaded is still not supported for now
Closes#3123 for standard python
Are these changes tested?
test using:
PYTHON=3.14 make testPYTHON=3.14 make test-integrationPython Build Release Candidate workflow was run: https://github.com/afeldman1/iceberg-python/actions/runs/25267237725
Are there any user-facing changes?
Just support of python 3.14