Skip to content

Add create_namespace_if_not_exists method - #725

Merged
HonahX merged 1 commit into
apache:mainfrom
ndrluis:namespace-exists
May 15, 2024
Merged

Add create_namespace_if_not_exists method#725
HonahX merged 1 commit into
apache:mainfrom
ndrluis:namespace-exists

Conversation

@ndrluis

@ndrluisndrluis commented May 10, 2024

Copy link
Copy Markdown
Collaborator

Resolves#709

@sungwy

sungwy commented May 13, 2024

Copy link
Copy Markdown
Collaborator

Hi @ndrluis thank you for working on this PR.

What are your thoughts on aligning the implementation with the way create_table_if_not_exists method is currently implemented in the abstract base class Catalog? The benefit I see with this approach is that we will only have to implement it once in the abstract base class, instead of having to make the changes across different catalog implementations.

@ndrluisndrluis changed the title Enable exception suppression during namespace creation@ndrluis Add create_namespace_if_not_exists methodMay 13, 2024
@ndrluisndrluis changed the title @ndrluis Add create_namespace_if_not_exists methodAdd create_namespace_if_not_exists methodMay 13, 2024
@ndrluis

ndrluis commented May 13, 2024

Copy link
Copy Markdown
CollaboratorAuthor

@syun64 Thank you for your review. I have made the requested change!

sungwy
sungwy approved these changes May 13, 2024
View reviewed changes

@sungwysungwy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👍

HonahX
HonahX approved these changes May 15, 2024
View reviewed changes

@HonahXHonahX left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding this method. @ndrluis

@HonahX
HonahX merged commit a268e5b into apache:mainMay 15, 2024
@ndrluis
ndrluis deleted the namespace-exists branch May 16, 2024 18:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sungwysungwysungwy approved these changes
@HonahXHonahXHonahX approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

create namespace if not exist

3 participants

@ndrluis@sungwy@HonahX