Uh oh!
There was an error while loading. Please reload this page.
Fix: Table-Exists if Server returns 204 - #739
Merged
Merged
Conversation
amogh-jahagirdar
left a comment
Contributor
There was a problem hiding this comment.
good catch @c-thiel and thanks for fixing! Change looks good, but if we could add a test similar to
iceberg-python/tests/catalog/test_rest.py
Line 666 in 20b7b53
c-thiel
commented
May 19, 2024
ContributorAuthor
@amogh-jahagirdar I added the test. Let me know if something else is missing! |
amogh-jahagirdar
approved these changes
May 19, 2024
HonahX
approved these changes
May 21, 2024
HonahX
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks for fixing this!
Fokko
approved these changes
May 23, 2024
Fokko
left a comment
Contributor
There was a problem hiding this comment.
Thanks @c-thiel for fixing this 🙌! Thanks @HonahX and @amogh-jahagirdar for the review 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#735