Uh oh!
There was an error while loading. Please reload this page.
fix: update all namespace properties in update_namespace_properties - #873
Merged
Conversation
kevinjqliu
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution! I have a few minor comments. Please feel free to tag me for re-review :)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
4 tasks
ranli
commented
Jun 30, 2024
ContributorAuthor
@kevinjqliu updated code based on your comments. |
kevinjqliu
left a comment
Contributor
There was a problem hiding this comment.
@ranli added a comment on readability of the test.
HonahX
approved these changes
Jul 4, 2024
HonahX
left a comment
Contributor
There was a problem hiding this comment.
@ranli Thanks for the contribution! LGTM! Thanks @kevinjqliu for reviewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 3rd bug listed at #864, where update_namespace_properties function only updates the first property and drops the rest