Uh oh!
There was an error while loading. Please reload this page.
fix(scan): validate deletion vector delete tasks - #3145
Conversation
linhongyu510
commented
Sep 4, 2026
CI follow-up pushed in 8ff9d12: removed the internal design note that failed the Apache license-header check, made the helper private, and updated the validated builder public API baseline. Verified locally with 15 targeted scan tests, rustfmt, clippy -D warnings, LICENSE/NOTICE checks, and cargo-public-api 0.51.0 output comparison. |
| field_defaults(setter(prefix = "with_")), | ||
| build_method(into = Result<FileScanTaskDeleteFile>) | ||
| )] | ||
| pub struct FileScanTaskDeleteFile { |
There was a problem hiding this comment.
We should remove all pub fields, and add pub getter to avoid inconsistent changes.
linhongyu510
commented
Sep 4, 2026
Addressed the review in 0228cd4: all |
Summary
FileScanTaskDeleteFileis builtTesting
cargo test -p iceberg scan::task::tests::test_delete_file_builder --libcargo test -p iceberg --lib delete_file_loadercargo test -p iceberg --lib row_filtercargo test -p iceberg --lib caching_delete_file_loadercargo test -p iceberg --lib delete_file_indexcargo test -p iceberg --libcargo clippy -p iceberg --all-targets --all-features -- -D warningscargo fmt --all -- --checkCloses#3135.