Unset no longer present table props while propagating props to HMS

[aokolnychyi]

I think HiveTableOperations does not unset table props that no longer there while propagating props to HMS.

[aokolnychyi]

@pvary, what do you think? I think if we drop table properties, they will be still in HMS, leaving props out of sync.

[pvary]

When we will have the full sync, we definitely want to do this.
OTOH we have to be careful with Hive related props like stats etc.

Tagged @marton-bod, as he has the property sync on his agenda

[marton-bod]

Hi Anton,
Good point. I agree that we should try to keep the Iceberg and HMS table props in sync (perhaps with some additional props present only in HMS, as needed by Hive). There are 2 directions here:

• Iceberg -> HMS: New and updated Iceberg properties are already pushed to HMS. As for deleted props, I can work on unsetting any HMS properties that are no longer present in the Iceberg table props. At first glance, this would be based on which keys are present in base.properties(), but are no longer present in metadata.properties() in doCommit.
• HMS -> Iceberg: Our plan is to extend the hive MetaHook interface to add a postAlterTable method which is currently missing that'd enable users to run an ALTER TABLE tbl SET TBLPROPERTIES('foo'='bar') DDL from hive and get the prop change pushed down the to the Iceberg table props as well.

[github-actions]

This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.

[github-actions]

This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale'