Skip to content

Fix partition spec and transforms in python - #1045

Merged
rdblue merged 1 commit into
apache:masterfrom
jun-he:jun/py-fix-partition-spec
May 18, 2020
Merged

Fix partition spec and transforms in python#1045
rdblue merged 1 commit into
apache:masterfrom
jun-he:jun/py-fix-partition-spec

Conversation

@jun-he

@jun-he jun-he commented May 17, 2020

Copy link
Copy Markdown
Contributor

This PR fixed a few bugs/issues in partition spec and transforms classes

  • In partition spec source_column.types should be source_column.type
  • type_id is missed or is mistakenly used as type_id() in multiple classes
  • In dates class, __str__ will cause RecursionError as it calls itself.
  • Fixed returning TruncateLong instead of TruncateInteger for TypeID.LONG.
  • Fixed truncate static method to use the right input parameter type_var.
  • added unit tests in python, similar to Java partition spec base test.

@rdblue
rdblue merged commit 49de952 into apache:master May 18, 2020
@rdblue

rdblue commented May 18, 2020

Copy link
Copy Markdown
Contributor

Thanks, @jun-he! Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants