avro: Extract DecoderResolver to provide cached ResolvingDecoder for resolving avro decoder - #1234
Merged
Merged
Conversation
openinx
reviewed
Jul 23, 2020
Comment on lines
+48
to
+52
| ResolvingDecoder resolver = fileSchemaToResolver.get(fileSchema); | ||
| if (resolver == null) { | ||
| resolver = newResolver(readSchema, fileSchema); | ||
| fileSchemaToResolver.put(fileSchema, resolver); | ||
| } |
Member
There was a problem hiding this comment.
Could simplify those lines as fileSchemaToResolver.computeIfAbsent ?
|
|
||
| private DecoderResolver() {} | ||
|
|
||
| private static final ThreadLocal<Map<Schema, Map<Schema, ResolvingDecoder>>> DECODER_CACHES = |
Member
There was a problem hiding this comment.
Q: Will it have problem when the GenericAvroReader , DataReader, SparkAvroReader share the same cache ?
Contributor
Author
There was a problem hiding this comment.
ResolvingDecoder is used by per record:
resolver.configure(decoder);
reader.read(resolver, reuse);
resolver.drain();
I think this pattern should be thread safe and can be shared.
…resolving avro decoder
JingsongLi
force-pushed
the
DecoderResolver
branch
from
July 24, 2020 05:47
6ecdaf4 to
b79bd90
Compare
Contributor
|
Looks great! I'll merge this. Thanks @JingsongLi! And thanks to @openinx for reviewing as well. |
rdblue
pushed a commit
to rdblue/iceberg
that referenced
this pull request
Jul 29, 2020
cmathiesen
pushed a commit
to ExpediaGroup/iceberg
that referenced
this pull request
Aug 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.