Uh oh!
There was an error while loading. Please reload this page.
Core: Pass storage credentials from LoadTableResponse to FileIO - #12591
Conversation
9bc2853 to
8db24dfCompareUh oh!
There was an error while loading. Please reload this page.
8db24df to
efe6592Compareefe6592 to
716a064Compare7848acb to
0c21c44Compare2f64867 to
0ca4c6bCompare
amogh-jahagirdar
left a comment
There was a problem hiding this comment.
Thanks @nastra! Passing through the credentials to the fileIO implementations looks great. Just had a comment for adding a JavaDoc on the new mixin interface since it is public.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
0ca4c6b to
7d75581Comparenastra
commented
Apr 2, 2025
thanks for the reviews @amogh-jahagirdar and @danielcweeks |
| } | ||
| @Override | ||
| public void setCredentials(List<StorageCredential> credentials) { |
There was a problem hiding this comment.
From what I observe, the this.storageCredentials can be wrapped in ImmutableList.copyOf. This way, credentials() doesn't have to create a copy every time.
There was a problem hiding this comment.
this will not work with Kryo ser/de because Kryo will try to add elements back after deserialization into the list and then fail
There was a problem hiding this comment.
I think the getter can be written this way (with additional field called copy):
first time getter assigns ImmutableList.copyOf() to copy field
subsequently copy field is returned directly until setter is called
No description provided.