Uh oh!
There was an error while loading. Please reload this page.
API: Use normalized JSON path to identify Variant fields - #12835
Merged
amogh-jahagirdar merged 1 commit intoApr 21, 2025
Conversation
rdblueforce-pushed
the
variant-metrics-use-normalized-path
branch
from
April 17, 2025 18:23
6ec3ae4 to
86308d4Comparerdblueforce-pushed
the
variant-metrics-use-normalized-path
branch
from
April 17, 2025 18:26
86308d4 to
fe675baComparerdblue
commented
Apr 17, 2025
| return names; | ||
| } | ||
| public static String toNormalizedPath(Iterable<String> fields) { |
ContributorAuthor
There was a problem hiding this comment.
This has to be public so that the Parquet conversion code can use it to translate a list of field names into a normalized path.
aihuaxu
approved these changes
Apr 17, 2025
aihuaxu
left a comment
Contributor
There was a problem hiding this comment.
I compared with rfc doc (https://datatracker.ietf.org/doc/rfc9535/) with unit tests.
ajantha-bhat
commented
Apr 18, 2025
Member
Will cherry-pick this to the next RC once merged. cc: @nastra |
amogh-jahagirdar
self-requested a review
April 18, 2025 22:21
amogh-jahagirdar
approved these changes
Apr 21, 2025
amogh-jahagirdar
commented
Apr 21, 2025
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the Parquet metrics conversion to use normalized JSON paths instead of joining field names using
.. A normalized path is a more reliable representation that preserves the distinction between[a.b][c],[a][b][c]and[a.b.c].This implements the changes from #12658. Currently, the spec does not cover how bounds should be stored for variants, but I think we are in agreement about using normalized paths, so I would like to get this in to avoid writing incorrect bounds in the 1.9.0 release.