Skip to content

Spark 3.4: Migrate tests in spark.source including refactoring Spark 3.5 tests - #13040

Merged
nastra merged 2 commits into
apache:mainfrom
tomtongue:migrate-spark3.4-source
May 13, 2025
Merged

nastra merged 2 commits into
apache:mainfrom
tomtongue:migrate-spark3.4-source

Conversation

@tomtongue

@tomtongue tomtongue commented May 13, 2025

Copy link
Copy Markdown
Contributor

Migrate Spark 3.4 tests based on JUnit 4 to Junit5 with AssertJ style. This is related to #7160

This PR migrates the following tests in spark.source to JUnit 5 with AssertJ:

  • TestBaseReader
  • TestFilteredScan
  • TestForwardCompatibility
  • TestIcebergSpark including refactoring Spark 3.5 tests
  • TestInternalRowWrapper
  • TestPartitionPruning including refactoring Spark 3.5 tests
  • TestPartitionValues including refactoring Spark 3.5 tests
  • TestSparkAggregates including refactoring Spark 3.5 tests
  • TestSparkDataFile
  • TestSparkReaderWithBloomFilter
  • TestStreamingOffset
  • TestStructuredStreaming including refactoring Spark 3.5 tests
  • TestWriteMetricsConfig including refactoring Spark 3.5 tests

Plus, add TestExpireSnapshotsAction which is partially migrated.

@tomtongue
tomtongue force-pushed the migrate-spark3.4-source branch from 6f44690 to d7a744d Compare May 13, 2025 15:46
@nastra
nastra merged commit ba75a11 into apache:main May 13, 2025
@tomtongue

Copy link
Copy Markdown
Contributor Author

@nastra Thank you!!

@tomtongue
tomtongue deleted the migrate-spark3.4-source branch May 13, 2025 17:04
anuragmantri added a commit to anuragmantri/iceberg that referenced this pull request Jul 25, 2025
…3.5 tests (apache#13040) (apache#1582)

Co-authored-by: Tom Tanaka <43331405+tomtongue@users.noreply.github.com>
devendra-nr pushed a commit to devendra-nr/iceberg that referenced this pull request Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants