Skip to content

API: Override StructProjection toString with that of underlying struct - #13251

Closed
manuzhang wants to merge 1 commit into
apache:mainfrom
manuzhang:fix-12414
Closed

API: Override StructProjection toString with that of underlying struct#13251
manuzhang wants to merge 1 commit into
apache:mainfrom
manuzhang:fix-12414

Conversation

@manuzhang

Copy link
Copy Markdown
Member

Closes#12414

@manuzhang
manuzhang requested a review from szehon-hoJune 9, 2025 06:33
@szehon-ho

Copy link
Copy Markdown
Member

hm not opposed to change, but curious, would it be better to also print the projection? Do you have a particular projection in mind you want toString for?

@manuzhang

Copy link
Copy Markdown
MemberAuthor

@szehon-ho In the case of #12414, it's PartitionData, where the info of projection is not useful.


@Override
public String toString() {
return struct.toString();

@stevenzwustevenzwuJun 17, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would disagree that StructProjection#toString print the full wrapped struct. It should only print the projected fields.

@github-actions

Copy link
Copy Markdown

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.

@github-actions

Copy link
Copy Markdown

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Partition info is not displayed in job description for RewritePositionDeleteFilesSparkAction

3 participants

@manuzhang@szehon-ho@stevenzwu