Spark 3.4: Prevent unnecessary failure when executing DML queries with identifier fields - #13448
Merged
Merged
Conversation
…h identifier fields
amogh-jahagirdar
approved these changes
Jul 2, 2025
amogh-jahagirdar
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the backport @szehon-ho ! Will merge when checks pass since it's a clean port
singhpk234
approved these changes
Jul 2, 2025
singhpk234
left a comment
Contributor
There was a problem hiding this comment.
LGTM as well, Thanks @szehon-ho !
stevenzwu
approved these changes
Jul 2, 2025
szehon-ho
force-pushed
the
3.4-fix-identifiers
branch
2 times, most recently
from
July 2, 2025 20:41
abd3bde to
3310513
Compare
Member
Author
|
Trying to fix the test, it broke as i changed the column to required. Looks like in Spark 3.4 , createDataset defaults to nullable column, which then cannot insert as its incompatbile with required column. |
szehon-ho
force-pushed
the
3.4-fix-identifiers
branch
from
July 2, 2025 20:45
3310513 to
5696df5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #13435